Twitch 클립 임베드 문제

[RGJ (Richard - Communiteq)]

Problem

Embedding a Twitch clip does not work, it somehow generates a bad parent parameter.

https://www.twitch.tv/paymoneywubby/clip/AmazonianMoralSwordCharlietheUnicorn-JoRQeBi1QJuyKfu2

At first I thought meta.tag had to do with Discourse Meta, but it’s the same value on every instance.

When you manually change the link into the actual hostname of the forum, the iframe will load.

A quick Google search leads me here, to another piece of software having the same issue, and the gist of that topic is

This suggests that it’s scraping the Twitch page for the Embed code. And is not replacing “meta.tag” with the correct parent.

Which seems to be the case here as well.

[Heliosurge (Dan DeMontmorency)]

위에 올려주신 링크입니다. 그 링크가 iframe을 로드하지 않는 건가요? 제 인스턴스(Tests-passed, 최신 버전)에서 게시글을 만들었을 때는 로드됩니다.

https://www.twitch.tv/paymoneywubby/clip/AmazonianMoralSwordCharlietheUnicorn-JoRQeBi1QJuyKfu2

하지만 여기 Meta에서는 로드되지 않습니다.

제 포럼에서 찍은 스크린샷입니다.

iftrane Customization > Theme component 및 사이트 설정을 통해 추가된 것이 아닐까 생각했습니다. 하지만 twitch는 어디에도 직접 추가되어 있지 않습니다.

버전 대시보드입니다.

추가 정보: 이 문제는 Google Pixel 8의 Chrome에서 발생합니다.

[RGJ (Richard - Communiteq)]

@Heliosurge

Screenshot from my forum.

On my tests-passed instance (same commit as yours), I get a regular onebox when I paste that link, just like on your forum. But when I add ?foo (or any other query parameter) I get the behavior like here on Meta. So I guess that’s a second bug (or at least: something I don’t understand)

But anyway… that’s a regular onebox. I want an embedded player (and that’s what I get when I manually “fix up” the parent parameter in the link through the dev tools inspector)

[Heliosurge (Dan DeMontmorency)]

Is the clip a bit different than this

https://www.twitch.tv/videos/1845242876?tt_medium=mobile_web_share&tt_content=vod

The above works on my instance for twitch video.

Okay was able to repo. As you said it is the clips that are not sharing correctly. Full twitch videos seem fine.

Interesting bug. I am wondering if it might be more on twitch’s side as Video works with player but the share clips doesn’t

[Falco]

Test

[Falco]

Tentative fix

https://github.com/discourse/discourse/pull/31080

[Falco]

Testing formats

https://www.twitch.tv/jenandaliona/clip/CrispyFriendlyLobsterFeelsBadMan-MelPMGMLiS9GFKea?filter=clips&range=all&sort=time

https://clips.twitch.tv/CrispyFriendlyLobsterFeelsBadMan-MelPMGMLiS9GFKea

https://clips.twitch.tv/embed?clip=CrispyFriendlyLobsterFeelsBadMan-MelPMGMLiS9GFKea&parent=meta.discourse.org

Looks like all is done here.