Missing title string for an "edit webhook" button

Canapin · January 22, 2025, 1:43pm

When you’re on a webhook event page /admin/api/web_hooks/3 for example:

The string is present on the webhooks page /admin/api/web_hooks.

Moin · January 22, 2025, 4:12pm

In German, I see “de.Bearbeiten,” so the problem is not a missing text but that the language is added in front.

Maybe this needs to be @title="edit" like “delete” in line 20.

github.com/discourse/discourse

app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs

3be699fe2


      
            {{i18n "admin.web_hooks.back"}}
          </LinkTo>
          
          <div class="admin-webhooks__summary">
            <h1>
              {{this.model.payload_url}}
          
              <DButton
                @action={{this.edit}}
                @icon="far-pen-to-square"
                @title={{i18n "admin.web_hooks.edit"}}
                class="no-text admin-webhooks__edit-button"
              />
          
              <DButton
                @action={{this.destroyWebhook}}
                @icon="xmark"
                @title="delete"
                class="destroy btn-danger admin-webhooks__delete-button"
              />
            </h1>

isaac · January 22, 2025, 4:18pm

@ted, looks like this was from a recent change

ted · January 27, 2025, 5:47am

Thanks for the report!

This has been addressed together with another issue here:

ted · February 3, 2025, 12:00am

This topic was automatically closed after 6 days. New replies are no longer allowed.

Topic		Replies	Views
I18n keys showing on Webhooks edit page Bug	3	361	March 7, 2024
Customize Text only works for some elements on the Site Bug	11	566	September 20, 2022
Missing "edit html&css" and "uploads" button for components Feature	8	1140	January 3, 2021
Can't find Admin > Customize > CSS/HTML Support	3	709	March 6, 2020
Translation missing: en.dashboard.problem.deprecated_linked_in_auth Bug fixed	14	150	August 25, 2024

Missing title string for an "edit webhook" button

Related topics