I18n keys showing on Webhooks edit page

bug
1

I’m seeing this on the Webhooks edit page with 3.3.0.beta1-dev:

image
image988×494 23.3 KB

Two of the sections and their checkbox labels appear to be showing i18n keys instead of the values of those keys. E.g., I’m fairly sure that

[en.admin.web_hooks.voting_event.group_name]

is not the intended header for whatever category that’s supposed to be.

3 Likes
2

Good catch!

You are not supposed to see the webhook of plugin that is not installed on your Discourse.

This is a regression from here:

Specifically here.
The symbols provided in TYPES don’t match the list values:

To the team, here is a possible solution: 
def self.types_with_prefix(prefix)
  TYPES.select { |key, _value| key.to_s.start_with?(prefix.to_s) }.values
end

def self.active
  ids_to_exclude = []
  unless defined?(SiteSetting.solved_enabled) && SiteSetting.solved_enabled
    ids_to_exclude.concat(types_with_prefix(:solved))
  end
  unless defined?(SiteSetting.assign_enabled) && SiteSetting.assign_enabled
    ids_to_exclude.concat(types_with_prefix(:assign))
  end
  unless defined?(SiteSetting.voting_enabled) && SiteSetting.voting_enabled
    ids_to_exclude.concat(types_with_prefix(:voting_topic))
  end
  unless defined?(SiteSetting.chat_enabled) && SiteSetting.chat_enabled
    ids_to_exclude.concat(types_with_prefix(:chat_message))
  end
  self.where.not(id: ids_to_exclude.flatten)
end
6 Likes
5

Thank you for reporting this issue :confetti_ball:

I fixed it today with in this PR

5 Likes
6

This topic was automatically closed after 2 days. New replies are no longer allowed.