Sorry to be dense, but I’m not quite sure if you’re asking me to review all of your code or just the use of the Discourse filter. It’s the right format in the sense that the filter expects you to modify the $output, and use the template tags to interpolate values. For more on that see this topic