Agregar nuevos webhooks y personalizar la carga útil del webhook

Ever wonder how to add new webhook types? Or how to reduce the payload? Here is the tutorial for the plugin authors. It demos how to add the session and user notification event types as well as customization to the payload. You can also check the plugin on GitHub while reading.

If you’d like to have a new webhook type supported by the team, bring up a feature request instead.

Before started, make sure you already understand webhook guide.

New webhook event type

A new webhook event type is defined in the database so that Ember client and webhook can find relevant information.

1.Seeding

Add a seed file in the following path of the plugin db/fixtures/001_custom_web_hook.rb.

WebHookEventType.seed do |b|
  b.id = 100 # start with a relative large number so it doesn't conflict with the core type
  b.name = "notification"
end

WebHookEventType.seed do |b|
  b.id = 101
  b.name = "session"
end

Then putting SeedFu.fixture_paths << Rails.root.join("plugins", "discourse-webhooks-example", "db", "fixtures").to_s into the plugin.

Admin dashboard needs the text to display the new event type. Adding them in config/locales/client.<language-code>.yml:

en:
  admin_js:
    admin:
      web_hooks:
        notification_event:
          name: "Notification Event"
          details: "When there is a new notification."
        session_event:
          name: "Session Event"
          details: "When there is a login or logout."

2. Connect with the internal DiscourseEvent or hook on your own

add_model_callback(:notification, :after_commit, on: :create) do
  # you can enqueue web hooks anywhere outside the AR transaction
  # provided that web hook event type exists
  WebHook.enqueue_hooks(:notification, # event type name
                        notification_id: self.id, # pass the relevant record id
                        # event name appears in the header of webhook payload
                        event_name: "notification_#{Notification.types[self.notification_type]}_created")
end

%i(user_logged_in user_logged_out).each do |event|
  DiscourseEvent.on(event) do |user|
    WebHook.enqueue_hooks(:session, user_id: user.id, event_name: event.to_s)
  end
end

3. Final step: Sidekiq Jobs

Adding a new method to the Jobs::EmitWebHookEvent:

Jobs::EmitWebHookEvent.class_eval do
  # the method name should always be setup_<event type name>(args)
  def setup_notification(args)
    notification = Notification.find_by(id: args[:notification_id])
    return if notification.blank? # or raise an exception if you like

    # here you can define the serializer, you can also create a new serializer to prune the payload
    # See also: `WebHookPostSerializer`, `WebHookTopicViewSerializer`
    args[:payload] = NotificationSerializer.new(notification, scope: guardian, root: false).as_json
  end

  def setup_session(args)
    user = User.find_by(id: args[:user_id])
    return if user.blank?
    args[:payload] = UserSerializer.new(user, scope: guardian, root: false).as_json
  end
end

An aside note, the payload is sent as if you are an administrator browsing a Discourse site. Be careful for what you sent.

Payload customization

There are two ways to reduce the payload size.

  1. Define a custom serializer.
  2. Uses plugin filter.

The first one is explicit to do. The second one involves a plugin API where you have the power to modify the payload. This enables the possibility to slice the JSON, i.e. @Lapinot suggested.

Plugin::Filter.register(:after_build_web_hook_body) do |instance, body|
  if body[:session]
    body[:user_session] = body.delete :session
  end

  body # remember to return the object, otherwise the payload would be empty
end

Final aside note, a {{plugin-outlet name="web-hook-fields"}} is now available in the web hook configuration page.

The plugin code is available under GitHub - erickguan/discourse-webhooks-example.

Thanks @erlend_sh to encourage me writing this tutorial and @tgxworld for sorting out the internals.

26 Me gusta

@fantasticfears Note that it isn’t recommended to run migrations in plugins. Instead I’ve updated the howto to create a fixture file that will automatically be run when db:migrate is invoked.

7 Me gusta

Fixture is better than migration but it doesn’t work with the plugin now. The plugin system includes only db/migrate but not fixture.

Ah ha I forgot to include the secret sauce.

https://github.com/discourse/discourse-narrative-bot/blob/5ae7c8c7495bc5af667a6125b790e656b83d9b10/plugin.rb#L19

10 Me gusta

I didn’t know there’s a new API register_seedfu_fixtures! Updated.

8 Me gusta

what do i have to do to make it just notification webhook and remove the session event ?

Can someone offer a hint here?

I need to submit this JSON payload when a new user is created:

{"email_address":"address of new user", "status": "subscribed"}

I guess I don’t know how to create a serializer.

This is easy.

class MySerializer < ApplicationSerializer
  attributes :email_address, :status
end

my_object = MyClass.new(email_address: "address of new user", status: "subscribed")
MySerializer.new(my_object).as_json
4 Me gusta

@fantasticfears Thanks for the writeup!

It needs a bit of tweaking to take account of the changes introduced in this commit.

  • You no longer need a setup_ method in Jobs::EmitWebHookEvent.

  • There’s now a WebHook a class method for formatting custom payloads via a serializer:

    WebHook.enqueue_object_hooks(type, object, event, Serializer) 
    

Also, I’m wondering about the thinking behind namespacing the payload with the event type? This makes it a little harder to use endpoints you don’t fully control, which expect certain attributes in the body.

def build_web_hook_body(args, web_hook)
   ....
   if ping_event?(event_type)
     body[:ping] = 'OK'
   else
     body[event_type] = args[:payload]
   end
  ...
end
2 Me gusta

Can you help me update the guide?

This is mainly for possible extension. Additional information can be serialized to other keys. But we relies on serializers now so it’s more or less useless.

2 Me gusta

@fantasticfears
Hola.

Estoy intentando conectar Discourse con APP usando webhooks.

He hecho la mayoría de las cosas, pero solo queda una.

Cuando creas un nuevo tema en Discourse, envías una carga útil que tiene muchos parámetros a APP.

Sin embargo, Slack solo recibe el parámetro ‘text’. Así que quiero personalizar la carga útil al usar webhooks.

¿Cómo cambio la carga útil al usar webhooks en Discourse?

COMO ESTÁ

{
  "post": {
    "id": 19,
    "name": "user",
    "username": "user",
    "avatar_template": "/letter_avatar_proxy/v2/letter/u/c0e974/{size}.png",
    "created_at": "2018-07-20T06:24:33.205Z",
    "cooked": "<p>Cool, now i have you, haha</p>",
    "post_number": 6,
    "post_type": 1,
    "updated_at": "2018-07-20T06:24:33.205Z",
    "reply_count": 0,
    "reply_to_post_number": null,
    "quote_count": 0,
    "avg_time": null,
    "incoming_link_count": 0,
    "reads": 0,
    "score": 0,
    "topic_id": 11,
    "topic_slug": "this-is-new-topic",
    "topic_title": "This is new topic",
    "display_username": "user",
    "primary_group_name": null,
    "version": 1,
    "user_title": null,
    "moderator": false,
    "admin": true,
    "staff": true,
    "user_id": 1,
    "hidden": false,
    "trust_level": 1,
    "deleted_at": null,
    "user_deleted": false,
    "edit_reason": null,
    "wiki": false,
    "topic_posts_count": 6
  }
}

A SER

{
   "topic_title": "This is new topic"
}

Saludos.

Hola, estoy intentando crear un webhook personalizado siguiendo esta guía y el plugin de ejemplo, pero no consigo que mis nuevos tipos de eventos personalizados aparezcan en la interfaz de usuario del webhook. Intenté instalar el plugin enlazado en esta guía en mi instancia de desarrollo local y los eventos de este plugin de ejemplo tampoco aparecen. Supongo que algo cambió entre 2017 y ahora que afecta a esto.

¿Alguien aquí sabe cómo hacer que el plugin de ejemplo en este tema funcione? Sospecho que el problema podría estar en el código de inicialización de la base de datos, ya que las nuevas entradas no aparecen en la respuesta de /admin/api/web_hooks. Tal como está ahora, esta guía no es funcional. ¡Gracias!

Hola! Creo que necesito ayuda

Estoy intentando agregar un webhook personalizado, lo cual he logrado y envía correctamente la carga útil a la URL del webhook. Lo único que no puedo lograr es habilitar el evento al configurar el webhook en el administrador. He seguido el tutorial anterior registrando el fixture, pero no aparece en el administrador.

Lo he intentado de un par de maneras:

SeedFu.fixture_paths << Rails.root.join("plugins", "<plugin_name>", "db", "fixtures").to_s
register_seedfu_fixtures(Rails.root.join("plugins", "<plugin_name>", "db", "fixtures").to_s)

Fixture:

WebHookEventType.seed do |b|
    b.id = 101
    b.name = "remove_like"
end

También agregué esto a la configuración regional:

en:
  js:
    plugin_name:
      placeholder: placeholder
    admin:
      web_hooks:
        remove_like_event:
          name: "Evento de Eliminar Me Gusta"
          details: "Cuando un usuario marca una publicación como la respuesta aceptada o no aceptada."

¿Me falta algo? ¿o se supone que debo hacerlo de alguna otra manera?

Vale, parece que ha sido un problema de caché o algo así, cuando lo instalé en otra instancia de Discourse sí que apareció.