Add support for secure uploads in chat

Contribute Feature
,
1

Continuing the discussion from 2.9.0.beta9: Security fix, bug fixes and more:

Why is this disallowed? In earlier versions it seemed to work fine with secure media.

1 Like
4

Secure Uploads in Chat arenā€™t supported at the minute, so it made that setting a little misleading. Thereā€™s more detailed info in the commit itself, as well as a workaround if you have server access: :+1:

https://github.com/discourse/discourse-chat/commit/93ab81c725faeca23fbe0bb597a5038382a711e3

4 Likes
5

Thanks @JammyDodger . Just noting as well that I am queued up on making secure media work with more areas, including chat, later in the year.

6 Likes
6

Just a kind reminder that secure media is important and useful for some Discourse users :pray:

3 Likes
7

This is definitely not forgotten, I am the one that will be working on this compatibility, I just have many other things on my plate. Will post updates here when they are ready :+1:

5 Likes
8

Sorry for being annoying about this, perhaps once every 6 month I can send a request to bump this into priority :blush:

2 Likes
9

6 months have passed and Itā€™s me again :yum:
Please allow uploads to chat when secure_uploads is enabled :pray:
See you in 6 months :heart:

4 Likes
10

In a recent Discourse update, thumbnail preview of images uploaded in chat is broken when secure-uploads is enabled.

I know ā€œThis condition can be overridden with DISCOURSE_ALLOW_UNSECURE_CHAT_UPLOADS at operator riskā€, but I wonder if thereā€™s any temporary solution for it? @martin

1 Like
13

Hi everyone! :waving_hand:

Just checking in on the status of this ā€” has there been any progress on making chat uploads compatible with secure_uploads?

1 Like
14

No, no progress and itā€™s still not yet prioritized.

This is also still true (perhaps more true):

I do very much want to get to this, but Iā€™m not sure when thatā€™ll happen.

What are you doing currently? Using chat but getting by without uploads?

When was the last time that got in your way?

Hearing little anecdotes here about how the lack of this feature is impacting you and others is helpful any time you have them to share.

1 Like
15

Thanks for the update!

I am building an internal Discourse for my company use. Same time bringing our instructions, todos, other stuff and our chatting to Discourse.

Now I am getting uploads for chat using the DISCOURSE_ALLOW_UNSECURE_CHAT_UPLOADS env setting. And I instructed that nothing private files/images should be shared using chat. Since this is internal only and forced 2fa and only employees use this Discourse this is fine.

Chat usage is discussing projects/coding/personal stuff so mainly sharing images using chat (photos of issues, personal stuff etc.).

So it is not ā€œbusiness criticalā€ but really nice to have since topics are using secure uploads and it would be great that chat messages used the same logic.

Still. Keep up the great work!

1 Like
16

I appreciate the extra context. We are doing something similar ourselves.

Iā€™m going to flip this over to Contribute > Feature and change the title since it feels like itā€™s become the de-facto home for the feature request to support secure uploads in chat.