Add theme dependencies in specification

(Michael Downey) #1

As a Discourse theme author, I want to be able to specify child/component themes that are required for my theme to work correctly, so the user (Discourse site admin) doesn’t have to manually go out and add/configure it.

We are working on a downstream theme to work alongside the Mozilla theme (thanks @LeoMcA!) but it’d be nice if we didn’t have to manually specify import their theme and manually link them. Could such a relationship be added to the about.json file?

(Joe Buhlig) #2

An aside, this would also benefit developers who build themes for clients. It’s becoming a more appealing setup to use a public theme and then tweak it for the client site. But more and more often, they want their customized theme in GitHub for pulling updates and allowing multiple people to work on them. It’d be great to embed the dependency somehow.

(Sam Saffron) #3

Asking for advanced features like this makes me :blush:, means the system is being used

Not against building this but needs very careful testing

(Leo McArdle) #4

I imagine it’d also be useful for you to be able to specify a particular version/commit that the theme depends on - that way, if we completely change something you’re depending on, it won’t all suddenly break on your end.

(Michael Downey) #5

Yes, good point … although makes it a bit more complex. :slight_smile:

(Joe Buhlig) #6

Maybe. If you can add the dependency as a GitHub link of sorts that allows a specific commit, branch, or tag, it gets easier. But that doesn’t mean the whole feature is easy.

(Michael Downey) #7

Or any non-GH Git repository :wink: