fzngagan
(Faizaan Gagan)
17. Juni 2020 um 03:37
1
In the events plugin, we currently override the mobile template. I’m very appreciative of the recent outlet additions to the mobile template which already make things a lot better. Just wondering whether we can have topic-list-after-title also on mobile so we can simply get rid of our override? This outlet is already available on desktop btw.
I’m happy to make a PR for this if the request makes sense.
4 „Gefällt mir“
david
(David Taylor)
17. Juni 2020 um 08:40
2
Sure, I think that sounds reasonable - I can’t think of any reason to have it on missing on mobile.
fzngagan:
get rid of our override
5 „Gefällt mir“
fzngagan
(Faizaan Gagan)
17. Juni 2020 um 08:44
3
This causes the topic-post-badge to be considered the same word as "text"
at the end of the link, preventing it from line wrapping onto its own line.
--}}
{{~raw-plugin-outlet name="topic-list-before-link"}}
<div class='main-link'>
{{~raw-plugin-outlet name="topic-list-before-status"}}
{{~raw "topic-status" topic=topic~}}
{{~topic-link topic class="raw-link raw-topic-link"}}
{{~#if topic.featured_link~}}
{{~topic-featured-link topic~}}
{{~/if~}}
{{~#if topic.unseen~}}
<span class="topic-post-badges"> <span class="badge-notification new-topic"></span></span>
{{~/if~}}
{{~#if expandPinned~}}
{{~raw "list/topic-excerpt" topic=topic~}}
{{~/if~}}
</div>
<div class='pull-right'>
{{raw "list/post-count-or-badges" topic=topic postBadgesEnabled=showTopicPostBadges}}
</div>
Is this the right place to add it? Just confirming.
1 „Gefällt mir“
david
(David Taylor)
17. Juni 2020 um 08:46
4
that seems to line up nicely with the desktop template
1 „Gefällt mir“
fzngagan
(Faizaan Gagan)
17. Juni 2020 um 08:56
5
3 „Gefällt mir“
fzngagan
(Faizaan Gagan)
17. Juni 2020 um 09:30
6
@david thanks for the merge.
3 „Gefällt mir“
david
(David Taylor)
Geschlossen,
17. Juni 2020 um 17:00
7
This topic was automatically closed after 7 hours. New replies are no longer allowed.