Adding topic-list-after-title outlet to the mobile template

fzngagan · June 17, 2020, 8:16am

In the events plugin, we currently override the mobile template. I’m very appreciative of the recent outlet additions to the mobile template which already make things a lot better. Just wondering whether we can have topic-list-after-title also on mobile so we can simply get rid of our override? This outlet is already available on desktop btw.

I’m happy to make a PR for this if the request makes sense.

david · June 17, 2020, 8:40am

Sure, I think that sounds reasonable - I can’t think of any reason to have it on missing on mobile.

fzngagan · June 17, 2020, 8:44am

github.com

discourse/discourse/blob/45eb97c2029a27455340809428ae4572b6731b8b/app/assets/javascripts/discourse/app/templates/mobile/list/topic-list-item.hbr#L25


  This causes the topic-post-badge to be considered the same word as "text"
  at the end of the link, preventing it from line wrapping onto its own line.
--}}
{{~raw-plugin-outlet name="topic-list-before-link"}}
<div class='main-link'>
  {{~raw-plugin-outlet name="topic-list-before-status"}}
  {{~raw "topic-status" topic=topic~}}
  {{~topic-link topic class="raw-link raw-topic-link"}}
  {{~#if topic.featured_link~}}
  {{~topic-featured-link topic~}}
  {{~/if~}}
  {{~#if topic.unseen~}}
    <span class="topic-post-badges">&nbsp;<span class="badge-notification new-topic"></span></span>
  {{~/if~}}
  {{~#if expandPinned~}}
  {{~raw "list/topic-excerpt" topic=topic~}}
  {{~/if~}}
</div>
<div class='pull-right'>
  {{raw "list/post-count-or-badges" topic=topic postBadgesEnabled=showTopicPostBadges}}
</div>

Is this the right place to add it? Just confirming.

david · June 17, 2020, 8:46am

that seems to line up nicely with the desktop template

fzngagan · June 17, 2020, 8:56am

Here’s the PR for this. DEV: Added topic-list-after-title outlet in the mobile template by fzngagan · Pull Request #10059 · discourse/discourse · GitHub

fzngagan · June 17, 2020, 9:30am

@david thanks for the merge.

david · June 17, 2020, 5:00pm

This topic was automatically closed after 7 hours. New replies are no longer allowed.