Allow sending test emails when mail is disabled?

rishabh · 17.Декабрь.2018 13:13:47

This is indeed a bit unpredictable, when disable email is set to non-staff,

sending a test mail to an admin email works as expected.
sending a test mail to any non-admin email fails silently.

IMO, we could:

allow an admin to send a test email to ANY email address
allow an admin to send a test email to any user (not just admins)
add a warning that a test email can only be sent to another admin

I like Option 1 because it’s the most obvious but 2 and 3 would also help make this less confusing.

github.com/discourse/discourse

app/controllers/admin/email_controller.rb

main


      
          
          def server_settings
            data = { delivery_method: delivery_method, settings: delivery_settings }
            render_json_dump(data)
          end
          
          def test
            params.require(:email_address)
            begin
              message = TestMailer.send_test(params[:email_address])
              Email::Sender.new(message, :test_message).send
          
              render json: { sent_test_email_message: I18n.t("admin.email.sent_test") }
            rescue => e
              render json: { errors: [e.message] }, status: :unprocessable_entity
            end
          end
          
          def preview_digest
            params.require(:last_seen_at)
            params.require(:username)

Тема		Ответов	Просм.
Email test area should warn if emails are disabled Feature	4	752	12.09.2018
Disable E-Mails set to non-staff but not sending out test email or administrator verification Support	1	1203	04.01.2022
The emails:test rake task should not report successful delivery when email is disabled Bug	3	674	08.07.2021
Discourse is sending emails even though emailing is disabled Bug	6	931	22.03.2019
Mails not working Self-hosting	3	655	18.09.2019

Allow sending test emails when mail is disabled?

Связанные темы