Amazon onebox issue

RaceProUK · 21 مايو 2015، 9:25ص

For some reason, the onebox doesn’t actually fill anything out
http://www.amazon.com/gp/product/B00H4SSB02

Doesn’t appear limited to just .com either:
http://www.amazon.co.uk/gp/product/B00H4SSB02

Edit: It seems the Amazon side is working OK:

accalia · 21 مايو 2015، 11:12ص

Hmm. Testing full link (for a different product):

Stripping parameters:

Stripping ref:

huh. it seems to be something about the onebox information for that product.

tgxworld · 15 يونيو 2015، 1:02م

http://www.amazon.com/gp/aw/d/193435659X

Test…

tgxworld · 15 يونيو 2015، 4:03م

I think I fixed it for most of the products.

https://github.com/discourse/onebox/pull/304

http://www.amazon.com/gp/product/B00H4SSB02 seems to be a special case.

downey · 15 يونيو 2015، 4:31م

Just a thought: It would be nice if this code also matched the smile.amazon.com domain (the rest of the URL is always the same) which allows non-profits to get a cut of the revenue.

riking · 15 يونيو 2015، 9:08م

Submit a PR to expand the URL matching:

github.com/tgxworld/onebox

lib/onebox/engine/amazon_onebox.rb

507776c0d


      
          require 'json'
          
          module Onebox
            module Engine
              class AmazonOnebox
                include Engine
                include LayoutSupport
                include HTML
          
          
                matches_regexp(/^http:\/\/(?:www)\.amazon\.(?<tld>com|ca|de|it|es|fr|co\.jp|co\.uk|cn|in|com\.br)\//)
          
                def url
                  return "http://www.amazon.#{tld}/gp/aw/d/" + URI::encode(match[:id]) if match && match[:id]
                  @url
                end
          
                def tld
                  @tld || @@matcher.match(@url)["tld"]
                end

tgxworld · 17 يونيو 2015، 3:29م

Is there a reason we try to scrape using mobile pages from Amazon? The desktop pages contains a description meta tag that we can use to improve reliability and avoid breaking Amazon onebox everytime they change their HTML.

github.com/tgxworld/onebox

lib/onebox/engine/amazon_onebox.rb

fix_amazon_onebox


      
          module Engine
            class AmazonOnebox
              include Engine
              include LayoutSupport
              include HTML
          
          
              matches_regexp(/^http:\/\/(?:www)\.amazon\.(?<tld>com|ca|de|it|es|fr|co\.jp|co\.uk|cn|in|com\.br)\//)
          
              def url
                return "http://www.amazon.#{tld}/gp/aw/d/" + URI::encode(match[:id]) if match && match[:id]
                @url
              end
          
              def tld
                @tld || @@matcher.match(@url)["tld"]
              end
          
              def http_params
                {'User-Agent' => 'Mozilla/5.0 (iPhone; CPU iPhone OS 5_0_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A405 Safari/7534.48.3'}
              end

codinghorror · 17 يونيو 2015، 6:09م

The idea was that mobile would have less cruft to sort through, if desktop is easier, go for it.

tgxworld · 21 يونيو 2015، 9:24ص

حسنًا، وصف الوسم التعريفي (meta tag) جيد جدًا، لكنني لست متأكدًا مما إذا كان عبارة «على Amazon.com. شحن مجانًا على العروض المؤهلة» مشتتًا للغاية. أود معرفة رأيك في هذا الأمر

tgxworld · 22 يونيو 2015، 10:24ص

حسنًا، جربت استخدام الوصف في وسم meta وأعتقد أنه يبدو أشبه بالإعلان أكثر من كونه يقدم معلومات إضافية عن المنتج.

سألتزم بصفحات الهاتف المحمول.

cc/ @sam

codinghorror · 26 يونيو 2015، 10:10ص

Have we pulled in the updated onebox @eviltrout?

eviltrout · 26 يونيو 2015، 2:53م

I just bumped it. I can’t say for sure if we were on the latest because our gemfile referenced a version that was pushed to Rubygems that wasn’t also set in our repo. I can confirm that now we are on the very latest onebox code.

neil · 13 يوليو 2015، 7:34م

Test again:

Looks like this bug isn’t fixed, or we still aren’t deploying the latest version of onebox.

tgxworld · 14 يوليو 2015، 1:04ص

The PR hasn’t been merged yet

https://github.com/discourse/onebox/pull/304

codinghorror · 14 يوليو 2015، 1:48ص

Ok can we please merge that @neil? And merge in onebox version update too.

codinghorror · 25 يوليو 2015، 3:35ص

I think it is working now at last, thank you very much @tgxworld!

techAPJ · 9 أكتوبر 2016، 7:37م

This is done now.

الموضوع		الردود	مرات العرض
Amazon Onebox Broken? Bug	29	2683	23 مايو 2023
Amazon Onebox broken Bug onebox	9	502	8 مايو 2024
Amazon onebox fails on my site, but works here Bug	19	3904	31 مارس 2016
Onebox and Amazon not working (for me) Support	6	177	2 يناير 2025
Amazon links are failing to onebox Bug	2	447	21 مارس 2021

الموضوعات ذات الصلة