Amazon onebox issue

Beitragen Fehler
1

For some reason, the onebox doesn’t actually fill anything out
http://www.amazon.com/gp/product/B00H4SSB02

Doesn’t appear limited to just .com either:
http://www.amazon.co.uk/gp/product/B00H4SSB02

Edit: It seems the Amazon side is working OK:

4 „Gefällt mir“
2

Hmm. Testing full link (for a different product):

Stripping parameters:

Stripping ref:

huh. it seems to be something about the onebox information for that product.

2 „Gefällt mir“
3

http://www.amazon.com/gp/aw/d/193435659X

Test…

4

I think I fixed it for most of the products.

https://github.com/discourse/onebox/pull/304

http://www.amazon.com/gp/product/B00H4SSB02 seems to be a special case.

1468×866 209 KB

7 „Gefällt mir“
5

Just a thought: It would be nice if this code also matched the smile.amazon.com domain (the rest of the URL is always the same) which allows non-profits to get a cut of the revenue.

8 „Gefällt mir“
6

Submit a PR to expand the URL matching:

7

Is there a reason we try to scrape using mobile pages from Amazon? The desktop pages contains a description meta tag that we can use to improve reliability and avoid breaking Amazon onebox everytime they change their HTML.

1 „Gefällt mir“
8

The idea was that mobile would have less cruft to sort through, if desktop is easier, go for it.

9

1242×126 42.2 KB

Hmm, der Meta-Tag für die Beschreibung ist ziemlich gut, aber ich bin mir nicht sicher, ob auf Amazon.com. *Kostenloser* Versand auf qualifizierte Angebote zu sehr ablenkt. Ich würde gerne eure Gedanken dazu hören :smiley_cat:

10

696×595 120 KB

Hmm, ich habe es mit der Beschreibung im meta-Tag versucht, aber ich finde, das wirkt zu sehr wie Werbung, anstatt mehr Informationen über das Produkt zu liefern.

Ich bleibe bei den mobilen Seiten.

cc/ @sam

4 „Gefällt mir“
11

Have we pulled in the updated onebox @eviltrout?

12

I just bumped it. I can’t say for sure if we were on the latest because our gemfile referenced a version that was pushed to Rubygems that wasn’t also set in our repo. I can confirm that now we are on the very latest onebox code.

2 „Gefällt mir“
13

Test again:

Looks like this bug isn’t fixed, or we still aren’t deploying the latest version of onebox.

14

The PR hasn’t been merged yet :wink:

https://github.com/discourse/onebox/pull/304

15

Ok can we please merge that @neil? And merge in onebox version update too.

1 „Gefällt mir“
16

I think it is working now at last, thank you very much @tgxworld!

3 „Gefällt mir“
18

This is done now.

4 „Gefällt mir“