[Android] Topic control dropdown activates keyboard

Bug
1

One of my users notified me that when you use Android and activate the “topic control”-dropdown, the keyboard activates, even though you can’t input anything anywhere. I confirmed it on my S8+ with Oreo using Chrome.

4 Likes
2

I can repro this as well. Not just “Topic Controls” but also the notification state controls. cc @joffreyjaffeux.

2 Likes
4

As a side note, pressing the wrench icon brings up admin tools (if you’re admin) - doesn’t look like you can fold that one back, and it looks weird when scrolling over a youtube onebox (the title of the youtube box is over the admin panel)…

6

Fixed by

https://github.com/discourse/discourse/commit/11c47f57f9458422467da8ba6d690d6a31cfa1c0

Thanks.

5 Likes
10

This has reverted for me on Android / Chrome 68 and Chrome 68 Beta - when selecting Topic Controls or Tracking options the keyboard pops up.

5 Likes
11

Also affects:

  • all drop downs in the topic timer modal
  • the category and tag drop downs in the composer
  • category, subcategory, and tag filters above the topic list
  • time range selector above /top and /u
5 Likes
12

Still pretty narrow for most users.

I can repro on my fully up to date Android device. Any ideas @joffreyjaffeux?

3 Likes
13

I pushed a fix which I think is fixing it. I tested it on an android device with chrome 68 and could reproduce before, and not after this fix. Let me know if it works for you @supermathie please.

6 Likes
15

Looks good to me. No more keyboard pop up on topic timer modal, topic controls, or the time range selectors. Still seeing the keyboard appear on the category and tag drop downs in the composer and filters above the topic list, but I’m pretty sure that pre-dated this regression. Those drop downs/filters have an actual search field that is gaining focus, likely calls for its own topic.

2 Likes
18

All better for me! Thanks!

1 Like
20

Yep, looks great now! Thanks for your work on this @joffreyjaffeux :heart_eyes:

1 Like
21

It’s kind of hard to automate testing on this sadly :confused: Thanks for looking at it. I learned a lot since I started writing select-kit and will need to dedicate some time in the future to improve all of this. There are a lot of things I could write in a better and safer ways now.

8 Likes
22

This topic was automatically closed after 29 hours. New replies are no longer allowed.