I’m working on migrating old oauth2 login to new interface. I listed some changes in a PR .
enabled_setting
in auth_provider.rb needs a deprecation warning.
Do we need a deprecation warning for background_color
too? This was an old option.
Some docs for auth_attributes
? It’s really hard to find where they go and what it expects.
4 Likes
david
(David Taylor)
November 20, 2018, 2:25pm
2
Thanks @fantasticfears , those three changes look good. I’m working on some related things over the next couple of weeks so I’ll review and create some basic documentation for the interfaces.
If you can wait a couple of weeks, I should have an implementation of this which will make things a lot easier for plugins!
Discourse now has the ability to connect and disconnect different authentication providers to your account. This is good, but there is still more we can do. These are things I intended to do with my last round of improvements, but have not managed to complete before needing to move on to another project.
Track ‘last used’ date for social login
Log ‘connect’/‘revoke’ events in UserHistories
Provide statistics to administrators
As @fantasticfears pointed out here , features like this ar…
5 Likes
Nice, nice! Feel free to cherry pick or copy my commit At least it’s running
2 Likes