Should we perhaps make a goal of having that setting be on by default in this release? As long as we ship default logos in the dark version it should be good?
Is there a way to only make it work with the “light” Discourse theme then?
At the moment, no, we don’t have a way to enable automatic dark mode for just one theme.
This feature is so useful, thank you for including in core.
I’ve done up a gif to demonstrate it on Windows. Discourse switches instantly, faster than the OS itself
Additional details here on my instance if keen.
Now I can read twice as much.
Please set this default to on. There is no user that wants to use dark mode and find a light theme when opening discourse website. There really is no point in having this default off.
Yes @pmusaraj is there anything preventing this from working by default in a new Discourse install?
Yes, we can enable this by default for new installs. The default sketch logo we ship looks great on dark mode as it is. The main issue IMO is that we need to allow admins to manage their dark mode color scheme (or disable it) in the wizard. I believe we need to make some changes to this screen:
I can start working on this in the current release cycle.
This is now in core as of last week (pull request), new Discourse installations will have dark mode enabled by default.
That’s great news! Thank you so much! You’re awesome!
this only seems to be working with logged-in users for me
logged out users should be defaulted on light mode when system is on light mode but instead are defaulted on dark mode and doesn’t switch to light mode when toggled on/off
Hmm can you repro the above @pmusaraj ?
I cannot reproduce this report. Tested on a new self-hosted site, skipped the wizard, and the default color scheme is Light, and the scheme flips to dark when I switch my device to dark mode.
Maybe you made changes to the default color scheme in the wizard? What do you see under Color Palette when you go to Admin > Customize > Themes > Default?
even though my default theme is light when you visit the site (logged out system on light mode) it appears dark mode
Is your browser set to dark theme?
Can you provide the URL to the site so I can test it as an anonymous user?
No, as it works on light when logged in and when logged out goes to dark same browser
Sure the link is LGBTChat - A safe space for LGBTQ+ people! (lgbtchatmc.com)
That is very strange, the base color definitions on your site are returning the dark colors, which is strange because the base color scheme is harcoded as the light one.
You can try rebuilding, and if that doesn’t work, try creating a new Light color scheme and use that in your theme.
After running a rebuild, this now works as expected! Thank you for your help @pmusaraj