Backup to DigitalOcean Spaces fails if uploads and backup are both set to S3

support
6

Hey, @gerhard, I have

DISCOURSE_S3_BACKUP_BUCKET: 'lc-backups'

Those backups are being stored in backups/multisitename, (so it would seem like the stuff I’ve seen lately about not being able to share buckets might not need to be true anymore, but that’s for another topic).

I thought that I’d set the upload bucket in one of the sites on this multisite install to lc-backups/uploads or maybe lc-backups/uploads/sitename, but it fails with: You cannot use the same bucket for 's3_upload_bucket' and 's3_backup_bucket'. Choose a different bucket or use a different path for each bucket.

But I am using a different path. I thought it might be related to https://github.com/discourse/discourse/commit/45b056b6151e3479b893cd6c01256c1248ded3f1 (even though it didn’t look like it), but I just upgraded and still no joy.

Is this a bug or am I wrong?

(And I’d just create another bucket and move on with life, but Digital Ocean isn’t allowing any more buckets to be created on NYC3 :angry:)

Thanks.