khenmu
(John Sweeney)
September 22, 2022, 2:16am
1
Being an insomniac, I noticed the following inconsistencies on the Badges page ;
Capitalisation
[Development] Great contributor ’s name isn’t capitalised in the usual way.
[Development] Amazing contributor ’s name isn’t capitalised in the usual way.
[Development] Amazing committer ’s name isn’t capitalised in the usual way.
[Development] Contributor ’s description begins with a lower case letter.
[Development] Great contributor ’s description begins with a lower case letter.
[Development] Amazing contributor ’s description begins with a lower case letter.
[Development] Amazing committer ’s description begins with a lower case letter.
Punctuation
[Community] Scribe ’s description has a full stop at the end.
[Development] Plugin Author ’s description has a full stop at the end.
[Development] Theme Author ’s description has a full stop at the end.
Spelling
[Development] Great contributor ’s description contains a typo: “contributed 25 accepted pull request” (“request” should be plural).
[Development] Amazing contributor ’s description contains a typo: “contributed 250 accepted pull request” (“request” should be plural).
5 Likes
jomaxro
(Joshua Rosenfeld)
September 22, 2022, 2:35am
2
Nothing wrong with nitpicking.
I did move this over to ux though, definitely stretching the definition of bug a bit too far.
3 Likes
khenmu
(John Sweeney)
September 22, 2022, 2:38am
3
Fair ‘nuff.
In the past I’ve encountered teams who treated text-related issues as “text bugs”, just for the sake of having everything needing changed all in one place. Still learning how you folks do things.
3 Likes
jomaxro
(Joshua Rosenfeld)
September 22, 2022, 2:40am
4
It’s all good! No harm in a quick category change.
If you’re feeling up to it, feel free to submit a PR with the necessary changes for review. Discourse is open source after all. If not, I imagine a member of the team, or another contributor will handle it at some point.
3 Likes
I think these are all our custom ones? I’ll have a look today.
Update: And they’ve been amended. Thanks for the report.
(Barring a few anomalies that I will continue to work-through… )
6 Likes
khenmu
(John Sweeney)
September 23, 2022, 3:55am
7
Hi, me again.
There are two badges with the same name and description. Paradoxically, they have been earned by a different number of users. It’s kinda weird!
Also, the bottom two have names that aren’t properly capitalised, descriptions which don’t begin with capital letters, and either they or the other Amazing Contributor are in the wrong section.
2 Likes
Yup. I believe it’s the way they’re generated. I’m looking into it.
I had to get a little help on this one, but it should all be smoothed out now with this:
discourse:main
← discourse:pullrequests/TheJammiestDodger/patch-1
opened 09:38AM - 04 Oct 22 UTC
Closes #66
Co-authored-by: TheJammiestDodger <96235848+TheJammiestDodger@user… s.noreply.github.com>
1 Like