Bottom of topic shows "There is 1 unread remaining" when there are actually 0 unread topics remaining

martin · April 20, 2022, 1:26am

I merged this pull request recently which should solve the issue, let me know if any similar issues are still occurring:

github.com/discourse/discourse

FIX: Issues with incorrect unread and private message topic tracking state

discourse:main ← discourse:issue/fix-topic-tracking-state-new-unread-issues

opened 06:37AM - 14 Apr 22 UTC

martin-brennan

+225 -19

This commit fixes two issues at play. The first was introduced in f6c852bf8e7f4…dea519425ba87a114f22f52a8f4 (or maybe not introduced but rather revealed). When a user posted a new message in a topic, they received the `unread` topic tracking state MessageBus message, and the Unread (X) indicator was incremented by one, because with the aforementioned perf commit we "guess" the correct last read post for the user, because we no longer calculate individual users' read status there. This meant that every time a user posted in a topic they tracked, the unread indicator was incremented. To get around this, we can just exclude the user who created the post from the target users of the `unread` state message. The second issue was related to the private message topic tracking state, and was somewhat similar. Whenever a user created a new private message, the New (X) indicator was incremented, and could not be cleared until the page was refreshed. To solve this, we just don't update the topic state for the user when the `new_topic` tracking state message comes through if the user who created the topic is the same as the current user. cf. https://meta.discourse.org/t/bottom-of-topic-shows-there-is-1-unread-remaining-when-there-are-actually-0-unread-topics-remaining/220817

Topic		Replies	Views
"Unread post" notifications for my own posts Bug	4	615	April 14, 2022
Unread messages blue numbers appearing in Latest lately (when they shouldn't)? Support	20	2987	November 12, 2020
The "new new" has been enabled on Meta Feature sidebar	32	2042	December 6, 2023
Notification counts are inconsistent and wrong Bug	20	1256	August 21, 2022
Discourse jumps back 20 posts in post history when navigating to new topic Bug	26	2650	August 28, 2023

Bottom of topic shows "There is 1 unread remaining" when there are actually 0 unread topics remaining

Related topics