martin
20. April 2022 um 01:26
21
Ich habe diesen Pull Request kürzlich zusammengeführt, der das Problem beheben sollte. Lassen Sie mich wissen, ob ähnliche Probleme weiterhin auftreten:
main ← issue/fix-topic-tracking-state-new-unread-issues
opened 06:37AM - 14 Apr 22 UTC
This commit fixes two issues at play. The first was introduced
in f6c852bf8e7f4… dea519425ba87a114f22f52a8f4 (or maybe not introduced
but rather revealed). When a user posted a new message in a topic,
they received the `unread` topic tracking state MessageBus message,
and the Unread (X) indicator was incremented by one, because with the
aforementioned perf commit we "guess" the correct last read post
for the user, because we no longer calculate individual users' read
status there. This meant that every time a user posted in a topic
they tracked, the unread indicator was incremented. To get around
this, we can just exclude the user who created the post from the
target users of the `unread` state message.
The second issue was related to the private message topic tracking
state, and was somewhat similar. Whenever a user created a new private
message, the New (X) indicator was incremented, and could not be
cleared until the page was refreshed. To solve this, we just don't
update the topic state for the user when the `new_topic` tracking state
message comes through if the user who created the topic is the
same as the current user.
cf. https://meta.discourse.org/t/bottom-of-topic-shows-there-is-1-unread-remaining-when-there-are-actually-0-unread-topics-remaining/220817
10 „Gefällt mir“