Brand Header

tgxworld · April 26, 2024, 8:38am

Oops sorry about that. Looks like there is a bug in the migration which will be fixed in

github.com/discourse/discourse-brand-header

FIX: Make `links` and `icons` setting migration more resilient

discourse:main ← discourse:make_migration_more_resistant_to_invalid_formats

opened 02:53AM - 25 Apr 24 UTC

tgxworld

+77 -40

This commit updates the migrations to assume that the old setting value may be …invalid so that we don't end up with a new setting which fails the objects schema validation. This is a follow up to 7e304e0a12115c6596fc64ff173368cba1a28e7b which added migrations for the `links` and `icons` settings. We have gotten reports of errors happening with the migrations because the value of the old setting before migration did not follow the "informal" format required previously. Since there was nothing enforcing the format for the value previously, we need to assume the worst possible cases in our migrations.

Topic		Replies	Views
Header Submenus theme-component official , header-submenus	80	34473	January 18, 2024
Custom Header Links (icons) theme-component official , custom-header-icons	99	28037	May 6, 2024
Tag Icons theme-component official , tag-icons	74	15878	April 8, 2024
Versatile Banner theme-component official , versatile-banner	91	38926	February 23, 2024
Easy Responsive Footer theme-component official , easy-responsive-footer	88	35218	May 7, 2024

Brand Header

Related Topics