GokulNC
(Gokul NC)
28 Febbraio 2020, 2:27pm
1
This plugin allows users to choose one badge with an image to show on their user card.
When I go to my Profile Preferences (https://dicourse.forum/u/xxx/preferences/profile ) with this plugin ON, I get the following error:
Uncaught Error: Could not find module `discourse/mixins/badge-select-controller` imported from `discourse/plugins/discourse-user-card-badges/discourse/controllers/preferences-card-badge`
Please fix this.
sam
(Sam Saffron)
29 Febbraio 2020, 9:11am
2
I believe @pmusaraj fixes some issues with this 10 days ago, are you sure you are on latest?
2 Mi Piace
sam
(Sam Saffron)
29 Febbraio 2020, 8:21pm
4
I mean latest version of the plugin, I guess you are unless you pinned to a version
We will investigate this over the next 2 weeks
6 Mi Piace
techAPJ
(Arpit Jalan)
5 Marzo 2020, 10:11am
6
Sembra che il plugin abbia subito una regressione dopo questo commit:
committed 12:17AM - 18 Oct 19 UTC
* DEV: Remove badge-select-controller
1. The `selectableUserBadges` computed ⌠property of `badge-title` was being incorrectly overwritten, which triggered computed-property.override deprecation.
2. The `badge-select-controller` mixin contained properties that were used either by `badge-title` component or `badges/show` controller, but none were being used by both. This change moves properties where they belong, and removes the mixin.
* Update app/assets/javascripts/discourse/controllers/badges/show.js.es6
Co-Authored-By: Robin Ward <robin.ward@gmail.com>
* Improve code brevity
@cvx , puoi dare unâocchiata qui?
5 Mi Piace
cvx
(Jarek Radosz)
5 Marzo 2020, 2:00pm
8
Risolto in:
master â controller-fix
merged 09:10PM - 06 Mar 20 UTC
A change in core (https://github.com/discourse/discourse/commit/ac06c87b43505a0d⌠d8f09da99e25cab5595abd99) broke the preferences of this plugin. This commit restores the missing properties.
Inoltre, sembra che questo plugin fosse praticamente inattivo dal maggio 2018. Ecco una correzione separata per la visualizzazione delle immagini dei badge:
master â display-fix
merged 09:12PM - 06 Mar 20 UTC
Broken since May 2018 https://github.com/discourse/discourse/pull/5814
7 Mi Piace