Bundling more popular plugins with Discourse core

[Ethsim2 (Ethan)]

i recall my failed rebuild started the old container automatically

[pfaffman (Jay Pfaffman)]

I think that happens if you run discourse-doctor.

[featheredtoast (Jeff Wong)]

@pfaffman

I don’t use discourse_docker (much?)

I’m assuming you mean the docker manager here.

We do have the ability to force a CLI update via these variables – the complication here is intervention was only needed if you had one of the plugins already installed.

Perhaps it would have been a better experience for self hosters had we forced a CLI update on everyone in these sorts of cases regardless.

[sandra.mccollum]

It all worked out in the end.

It was just a little disconcerting at first till I realized I had to go into the command line, remove plugins and rerun.

Fortunately, the end of the message on the first cli rerun indicated what had to be removed.

[pfaffman (Jay Pfaffman)]

@featheredtoast

I’m assuming you mean the docker manager here.

Oops. Right.

@featheredtoast

Perhaps it would have been a better experience for self hosters had we forced a CLI update on everyone in these sorts of cases regardless.

I think it’s a better experience if cdck errs on the side of doing a command line rebuild that will certainly work even if it might not be necessary rather than a more convenient one-click upgrade that might crash your site and require you to figure out how to do a command line rebuild.

[sam (Sam Saffron)]

@LeoDavidson

Tidying up your code slightly isn’t worth breaking people’s sites and wasting their time.

This is a complete misunderstanding of the situation.

This change has unblocked tremendous amounts of velocity for the team. Changes that in the past would take us many hours to work through can now take us minutes.

Take adding /filter support for assign and solved. Something I did last week. Yes, it was possible in the past but it required cross repo coordination which was very complicated to pull off, now we can do this stuff easily in 1 commit.

The end result is that the quality/stability and velocity of improvements for core plugins increases. It also gives us a better extensibility story overall cause we are less reticent to improve our extensibility story.

[david (David Taylor)]

@featheredtoast

Perhaps it would have been a better experience for self hosters had we forced a CLI update on everyone in these sorts of cases regardless.

@pfaffman

I think it’s a better experience if cdck errs on the side of doing a command line rebuild

We did force a CLI rebuild for each batch of bundled plugins

• bump image to discourse/base:2.0.20250710-0019 (#276) · discourse/docker_manager@5d90bc7 · GitHub

• bump image to discourse/base:2.0.20250715-0020 (#277) · discourse/docker_manager@ec799c4 · GitHub

• bump image to discourse/base:2.0.20250722-0020 (#280) · discourse/docker_manager@9ffff5e · GitHub

I haven’t seen any reports of failed UI rebuilds, so I think this strategy successfully pointed people to the CLI rebuild. Those CLI rebuilds then provided the ‘hint’ messages about removing lines from app.yml.

[pfaffman (Jay Pfaffman)]

@david

I haven’t seen any reports of failed UI rebuilds,

My bad. I thought I’d seen a few, but I bet you’re paying closer attention than I am!

Sorry about that