Can't view user cards on Meta - cakeday error

bug
1

When I go to view a user card today, I get just a white box, and this error in my google chrome browser:

Uncaught Error: Could not find module discourse/helpers/fa-icon imported from discourse/plugins/discourse-cakeday/discourse/components/emoji-images

I tried first on a user with a cake and got just the white box, then got the error again on a user without a cake.

2

Hmm can we repro @tgxworld?

3

I don’t remember which URL I was on, but I’m pretty sure it was in a Topic (which had a user showing a cake)

4

I can see the error here as well

https://meta.discourse.org/cakeday/anniversaries

5

Have you tried a different browser ?

I’m not seeing any problems or getting any error messages in the console using Vivaldi latest.

6

that was in Chrome, here’s the error in Safari (I was not logged in)

It happens once I click on a profile who’s cake-day is today.

screenshot_2056.png979×549 101 KB

7

I don’t have a Mac so I can’t test Safari, but I can’t reproduce that in any of my browsers. davegomez’s card displayed fine and error free for me.

IE11
Edge
Chrome
Opera
Opera Dev
Firefox
Firefox Dev
Vivaldi

So this is a Mac - Safari - only Bug?

8

I’ve been getting the exact same error, http://www.onlinearsenal.com/cakeday/birthdays when clicking on either avatar, on a mac, happening in Safari, Chrome, Firefox, logged in or logged out.

It’s happening on the user preferences/messages screen too, completely wiping the content of the page out once I’ve set the birthday (though it may just be because the birthday is today? - edit: just got someone else to check and they can access their messages/preferences when their birthday is set NOT to today).

The emoji works fine by the way, if you go into a topic that the person has used then it’s there http://www.onlinearsenal.com/t/planned-maintenance/349/10

I don’t know much about the discourse core and how it reads files so forgive my ignorance, but I’d guess from that error message and this commit that discourse/helpers/fa-icons has moved to discourse-common so the path may be wrong?

https://github.com/discourse/discourse/commit/be1d74d20772e3a4ed2b3daed9700249024a133f

1 Like
9

That seems plausible. I can recreate this on Meta too using Google Chrome (so it isn’t Safari specific).

My repro steps,

  1. Visit Discourse Meta
  2. Scroll down till you get till you see someone who has an anniversary on 9/24 (today’s date)
  • Side note: Shouldn’t Today’s Anniversaries being showing these people?
  1. Click on their user card

Actual Result:
Nothing happens, it acts like the click never took place
Dev console has an error.

Cake-Day-Error.gif799×480 2.08 MB

4 Likes
10

Thanks, I was able to reproduce the error with Windows 10 Vivaldi latest following those steps.

  function requireFrom(name, origin) {
    var mod = registry[name];
    if (!mod) {
      throw new Error('Could not find module `' + name + '` imported from `' + origin + '`');
    }
    return require(name);
  }
1 Like
11

The console errors aren’t happening for me today on Discourse Meta

I can see cakes if i click on a user’s card & their anniversary is today (sept 25)

screenshot_81.png2046×924 282 KB

12

Yup, this commit seems to be the fix for that particular issue
https://github.com/discourse/discourse-cakeday/commit/948cf4f5cea332d95fc7222282a44ccbb38806e0

6 Likes
13

I am from The Hopscotch Forum and this came up:

Screen Shot 2016-09-30 at 4.03.38 PM.png2556×1524 570 KB

Those upcoming birthday dates have already passed. It is now 30th of September, 2016.

14

Is this resolved and can it be closed @tgxworld?

15

Yup the bug in this topic has been resolved.

I’l tracking

in another topic.

3 Likes