Categories not displayed in reseed modal

Moin · October 28, 2024, 5:37pm

I updated my admin guide at Admin → Site Texts and noticed that the categories are no longer displayed in the modal

The <span> element is empty

The categories are included in the response payload from the request

So there is probably a problem here:

discourse/discourse/blob/311c042700f986d7af9091c84d0cb44661740bd2/app/assets/javascripts/admin/addon/components/modal/reseed.hbs#L22


      
              <legend class="options-group-title">
                {{i18n "admin.reseed.modal.categories"}}
              </legend>
              {{#each this.categories as |category|}}
                <label>
                  <Input
                    class="option"
                    @type="checkbox"
                    @checked={{category.selected}}
                  />
                  <span>{{category.displayName}}</span>
                </label>
              {{/each}}
            </fieldset>
          {{/if}}
          <br />
          {{#if this.topics}}
            <fieldset>
              <legend class="options-group-title">
                {{i18n "admin.reseed.modal.topics"}}
              </legend>

kris.kotlarek · November 6, 2024, 4:10am

Thank you @Moin for reporting this bug.

I just fixed it in this PR

github.com/discourse/discourse

FIX: correctly display category name in replace text modal

discourse:main ← lis2:reseed-bug

opened 02:28AM - 06 Nov 24 UTC

lis2

+12 -1

Bug introduced in this PR https://github.com/discourse/discourse/pull/23232 T…he previous modal was using `category.name` https://github.com/discourse/discourse/pull/23232/files#diff-bfae353a2f3457780e5c281b6a165261cfe552dd9dd791f3859e52d60e22be7fL20 Demo <img width="643" alt="Screenshot 2024-11-06 at 1 26 28 PM" src="https://github.com/user-attachments/assets/a1e56965-fea7-4951-9e28-e680fb3cc714">

Moin · November 6, 2024, 9:24am

Interesting
I thought it was introduced in DEV: allows to alter category name/description by jjaffeux · Pull Request #28263 · discourse/discourse · GitHub

Topic		Replies	Views
Reorder Categories stopped working? Bug	9	399	November 14, 2023
Top topics text missing Bug fixed	7	75	August 16, 2024
Bug on topic interface after an update \|\| Resolved Support	9	903	August 5, 2021
Categories show as undefined Bug	5	564	October 30, 2020
Number of topics not showing beside categories in category dropdown Support	11	599	October 16, 2020

Categories not displayed in reseed modal

Related topics