Category logo deleted after some edit

Bug
1

I noticed a little bug on Discourse, and I managed to find the steps to reproduce it :

  • Edit a category that has a logo and change the parent category
  • After 24/48 hours, the logo image will give an error 404, you’ll have to reupload the logo.

It may happen when we edit something else, like the description but I only tried this steps two days ago, and I can confirm tonight that there is a little bug here.

My forum was up to date at the time. And I didn’t see anything related to this issue since. If it’s the case, my apologies.

3 Likes
2

Hmm @sam does this help you diagnose the other strange upload issue?

3

In your admin staff action logs, can you look for change category settings and see what the category’s logo url was changed to?

If it doesn’t start with /uploads but includes https://yoursitedomain.com/uploads, something is off. I’ve seen this on another forum that we host but I couldn’t replicate the issue and re-uploading the image worked.

2 Likes
4 
ID catégorie: 26
Nouveau (new): //iunctis.fr/uploads/default/original/1X/dd3017f3ad31a63a56bbe68e7dfd1240479cde35.png
Précédent (old) : /uploads/default/original/1X/dd3017f3ad31a63a56bbe68e7dfd1240479cde35.png

(This is when I reuploaded the logo img)

You’re right, there is something wrong with the path

3 Likes
5

Can you try upgrading to latest and then reupload the logo? I’m still having trouble trying to reproduce this so it could be a regression that has been fixed.

6

Updated my Discourse 5 min ago and changed a setting. It still change the path of the logo : (here the chronological order of the logs)

change category settings
auto_close_based_on_last_post

Category ID: 18
New: t
Previous: f
/c/podcasts

change category settings
logo_url

Category ID: 18
New: //iunctis.fr/uploads/default/original/2X/c/c62958c95ad579ade24babb9fbb6ad3290be2a14.png
Previous: /uploads/default/original/2X/c/c62958c95ad579ade24babb9fbb6ad3290be2a14.png
/c/podcasts

When I reuploaded the logo image :

change category settings
logo_url

Category ID: 18
New: /uploads/default/original/2X/1/1e8ff2b5d505e8e830b2898c91ced03615f6ed32.png
Previoust: //iunctis.fr/uploads/default/original/2X/c/c62958c95ad579ade24babb9fbb6ad3290be2a14.png
/c/podcasts
2 Likes
7

I will have a look fist thing tomorrow.

2 Likes
8

Here’s the fix.

https://github.com/discourse/discourse/commit/641b95f655f0f653e3f0602d01729545ae8450ab

Update to latest, and re-upload any missing images.

2 Likes