Changing js.browser_update text doesn't apply on no JS views

Supporto
1

  1. Change js.browser_update in Customise > Text.

  2. Open Discourse in IE10

  3. Default message is shown instead of customised one

2

AFAIK JS text customizations run in Javascript. Since our mode for old browsers is plain HTML without Javascript, anything JS won’t run in there. This behavior is expected.

1 Mi Piace
Customised js.browser_update message ignored
3

It’s set here. https://github.com/discourse/discourse/blob/master/vendor/assets/javascripts/browser-update.js.erb#L29

So it should be applicable. :man_shrugging:

1 Mi Piace
4

Oh, that won’t work anymore as we are removing all globals, with I18n being the one that was removed last week.

It may work after a rebuild @zcuric.

3 Mi Piace
5

Not working unfortunately. We did a release today and rebuild the app, same thing.

6

I have the same problem. I thought when I first changed js.browser_update it did display on an old browser (but I’m not 100% sure now), but today I see that it shows the original text. Is there any way round this… maybe treating this particular message differently, as mostly when this message is displayed Javascript won’t be on? Maybe a short plugin?

7

Il motivo per cui hai visto questo funzionamento su un browser e poi non su un altro potrebbe essere che alcuni browser molto vecchi non supportano la traduzione lato client, mentre altri sì.

Proviamo prima a eseguire la traduzione e, se non funziona, ripieghiamo su un’istanza codificata in modo fisso del messaggio predefinito in inglese:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/scripts/browser-update.js#L50

Sfortunatamente non c’è molto altro che possiamo fare al riguardo. Speriamo che le persone abbandonino quei browser a un certo punto.