"clearfix" for User Summary "top-section"

UX
1

Pasted image1144×451 53.2 KB

Personally I’ve added the following to custom CSS to allow me to style it correctly:

@import "common/foundation/mixins";
.container .user-table .top-section {
    @include clearfix();
}
2 Likes
2

Wait what is the bug here?

3

The top-section div height should extend to the bottom of the two lists (top replies and top topics), i.e. the height of its content.

Not doing so:

  • can cause weird browser content placement depending on browser, version etc.
  • which is not worth the time in testing - easier just to put the clearfix in.
  • makes it difficult to style (i.e. add a background colour behind that section)
2 Likes
4

I agree, just pushed the fix :thumbsup:

https://github.com/discourse/discourse/commit/d3ee48a316f4db4ea33f99f05966b56f0fc41586

3 Likes