Clicking on Docs Card Filter reload the page

Don · March 31, 2024, 10:54am

Hello

I’ve noticed if I click the docs card filter it reloads the page. It seems it’s related with the component latest update. DEV: Update linting by CvX · Pull Request #13 · discourse/discourse-docs-card-filter · GitHub

Which change the onclick to

github.com

discourse/discourse-docs-card-filter/blob/1fe5375a9d026e4df4b1e52456f2a7c17dcc5af6/javascripts/discourse/templates/components/category-wrapper.hbs#L1-L5


      
          <a
            {{on "click" this.selectCategory}}
            href
            class="docs-card-box category-card card-{{categorySlug}}"
          >

github.com

discourse/discourse-docs-card-filter/blob/1fe5375a9d026e4df4b1e52456f2a7c17dcc5af6/javascripts/discourse/templates/components/tag-wrapper.hbs#L1-L5


      
          <a
            {{on "click" this.selectTag}}
            href
            class="docs-card-box tag-card card-{{tag.id}}"
          >

But in js I think it should use the event?.preventDefault();?

github.com

discourse/discourse-docs-card-filter/blob/1fe5375a9d026e4df4b1e52456f2a7c17dcc5af6/javascripts/discourse/components/category-wrapper.js#L16-L25


      
          @action
          selectCategory() {
            this.get("router").transitionTo("docs.index", {
              queryParams: {
                category: this.category.id,
                order: this.order,
                ascending: this.ascending,
              },
            });
          },

github.com

discourse/discourse-docs-card-filter/blob/1fe5375a9d026e4df4b1e52456f2a7c17dcc5af6/javascripts/discourse/components/tag-wrapper.js#L15-L24


      
          @action
          selectTag() {
            this.get("router").transitionTo("docs.index", {
              queryParams: {
                tags: this.tag.id,
                order: this.order,
                ascending: this.ascending,
              },
            });
          },

Thank you

CvX · April 2, 2024, 10:15am

Fixed in FIX: Use proper links in category/tag cards by CvX · Pull Request #14 · discourse/discourse-docs-card-filter · GitHub

Thanks for the report!

Don · April 2, 2024, 10:31am

Thanks @CvX, Category filtering works great but it seems there is an issue with tags.

CvX · April 2, 2024, 10:36am

Whoops, copy’n’paste error FIX: Fix tag links (followup to #14) by CvX · Pull Request #15 · discourse/discourse-docs-card-filter · GitHub

CvX · April 3, 2024, 10:15am

This topic was automatically closed after 24 hours. New replies are no longer allowed.

Topic		Replies	Views
Need to click twice to de-select a category filter in Docs bug docs	5	384	May 26, 2023
The Docs button on meta.discourse support	2	792	August 7, 2021
Docs plugin does not filter tags after selecting category bug docs	0	240	June 6, 2023
Clicking on a category doesn't filter the right topics bug	38	1519	September 19, 2022
Discourse Docs Card Filter theme-component official , docs , docs-card-filter	42	6966	September 12, 2023

Clicking on Docs Card Filter reload the page

Related Topics