Command Shift Return is inconsistent

techAPJ · January 12, 2022, 1:35pm

Here’s the PR:

github.com/discourse/discourse

FIX: navigate to topic/PM regardless of Shift key press

discourse:main ← techAPJ:shift-ninja-mode

opened 01:06PM - 12 Jan 22 UTC

techAPJ

+3 -1

Currently when pressing Shift key and hitting Reply button the user stays on th…e post they are on and does not get navigated to newly created topic/PM/reply. This is fine for replies but creates confusion when composing a new topic/PM. This commits makes it such that pressing Shift key and Reply button (or ctrl-shift-enter / cmd-shift-enter) works only for replies and not for new topic/PM. The user will always be navigated to new topic/PM.

Awaiting @sam’s review.

Topic		Replies	Views
Discourse jumps back 20 posts in post history when navigating to new topic, again bug	19	798	October 18, 2023
Cursor jumping around in composer / editor text box bug composer	19	1355	August 25, 2023
Discourse jumps back 20 posts in post history when navigating to new topic bug	26	2350	August 28, 2023
Options to disable hijack of CMD+F / CTRL+F and "/" keys for search? feature keyboard-shortcuts	45	46707	June 25, 2019
Reducing the frequency of display for the warning "Draft is being edited in another window." feature	34	2342	December 4, 2023

Command Shift Return is inconsistent

Related Topics