Shortcut to reply prints an "R" into the composer window

(Jeff Wong) #1

Looks like we’ve got a regression where hitting R to bring up the reply composer while viewing a post prints an “R” in the composer window, where it should be a blank composer. I can reproduce this on both meta and try.

Possibly due to the recent composer work, @nbianca ?

4 Likes

Quote Post Using Keyboard Includes “q” in Quoted Text
(Florian) #2

In addition, it seems that reply to post via r is not working anymore, shift + r shows the above-mentioned behavior.

0 Likes

(Joshua Rosenfeld) #3

Reply to post also prints an r into the composer, but it works. Have you selected a post to reply to first via j and k?

4 Likes

(Jeff Wong) #4

Ninja’d!

I also noticed that the same issue exists on the r shortcut, too

1 Like

(Florian) #5

Thanks for pointing. I was unaware of that necessity, learning new Discourse features every day :nerd_face:

2 Likes

(Joshua Rosenfeld) #6

Yep, without it Discourse doesn’t know which post you’re replying to :smiley:.

1 Like

(Florian) #7

I thought it takes the one which is active in the address bar, e.g, 107202/4 or 107202/5 (it somehow already knows which post I’m looking at).

1 Like

(Joffrey Jaffeux) #9

Might be ember3 , will look tomorrow

5 Likes

(Joffrey Jaffeux) #10

Should be fixed by:

https://github.com/discourse/discourse/pull/6930

9 Likes

(Régis Hanol) #11

We can’t do that based on the URL alone when there are multiple posts in the viewport, we can’t know which one you are replying to :wink:

4 Likes

(Florian) #12

Somehow I knew that I was missing something :slight_smile: Thanks for the clarification!

1 Like

(Jeff Atwood) closed #13
0 Likes