CommonMark testing started here!

Feature
29

Shouldn’t those render as test?.. and test!.. (i.e. three dots rather than two)?

30

Strongly depends on which color you like your bike shed :smile:

8 Likes
31

I guess the idea is that there are indeed three dots, but one of them is part of the question mark (or exclamation mark) :wink:

?.. !..

4 Likes
32

Not quite. Typographically, three dots are an ellipsis and and ellipsis is always three dots. There is no two to ellipsis and I am not aware of any style guide that suggests that the question mark or exclamation mark can replace one of the dots. By contrast, there are plenty of recommendations that suggest the use of a punctuation mark plus three dots (and, while we’re at it: to separate them from the punctuation mark with a space):

http://thewritepractice.com/how-to-use-an-ellipsis-correctly/

1 Like
33

I suggest you open this on the markdown it Github issues page cause we are simply consuming the functionality

6 Likes
34

Woo markdown tables!

1 Like
35

I did. They are using Russian typography and they’re basically sending the ball back to you by answering:

you can disable replacer and add your own if you don’t like existing one.

36

We do not care about this specific issue and will not be working on it.

1 Like
37

The hide details feature doesn’t work properly on meta:

Summary

This text will be hidden

38

Now we just need a nifty composer option to insert a table and we’ll be golden. :pray:

39

You need to write it

[details=Summary]
This text will be hidden
[/details]
Summary

This text will be hidden

1 Like
40

Makes sense. Then the composer options menu needs a tweak to fix how it inserts it.

7 Likes
41

Thanks… fixed per:

https://github.com/discourse/discourse/commit/c1560d8195f40dc048b8ad605ef8a67a516c64d6

Should be deployed here shortly.

6 Likes
42

It looks like the right align in the table is not working:

|  Tables  |      Are      | Cool |
|---|:---:|---:|
| col 1 is |  left-aligned | $100 |
| col 2 is |    centered   |  $52 |
| col 3 is | right-aligned |   $9 |
Tables Are Cool
col 1 is left-aligned $100
col 2 is centered $52
col 3 is right-aligned $9
3 Likes
43

Yeah, our sanitizer needs a fix there, added to my list

5 Likes
44

And table alignment stuff is fixed :sparkles:

I am now almost done with core and core plugin changes.

Only little bit left is some extra BBCode support, which I will work on tomorrow.

To celebrate I have exposed the site setting to enable CommonMark

https://github.com/discourse/discourse/commit/fbb5600c8e68f59fba0bcf89708fdcfff5ca18a9

9 Likes
45

It seems that footnotes are not working yet. :frowning:

Footnote[^easy]

[^easy]: One footnote

Option Description
data path to data files to supply the data that will be passed into templates.
engine engine to be used for processing templates. Handlebars is the default.
ext extension to be used for dest files.
neu Footnote 1 link[^first]

[^first]: Footnote can have markup

46

It is a plugin per: https://github.com/markdown-it/markdown-it-footnote

After I am done fixing this BBCode stuff I am going to have to clean up existing plugins. Once that is done I will do some posts that demonstrate how to re-package plugins, it is really easy.

8 Likes
47

Here’s a weird :bug:

This is [a link with a #bug]().

will render as :arrow_down_small:

This is a link with a #bug.

5 Likes
48

Cool, nice report, fixed per:

https://github.com/discourse/discourse/commit/c6b83f47140b4685c4a8f7a466d1e5673f11f898

2 Likes