sam
(Sam Saffron)
June 26, 2017, 12:44pm
1
Per our migration plans , I just enabled markdown.it at Meta.
It is an excellent CommonMark compliant engine. I expect quite a few edges to be found during this period of testing.
Do not open bugs about the new Engine , just reply here.
I/we will be updating the top post here with the list of issues and striking out stuff as it is fixed.
Current known issues (to be fixed)
Onebox vanishes after you start typing and works not-super consistently
pending approval does not render
Quote without preceding empty line does not work.
Onebox of reply is missing tons of info and not rendering right
When quoting the composer sometimes inserts a quote
block in the middle of a line (not a new bug but broken with new engine)
Onebox bypass is not working
Table is not showing up styled in preview
Details composer toolbar generating inline details
Emoji → Image conversion (when posing Emoji’s via a phone) is not implemented yet.
2 polls in a post seems to be … not that good.
Sanitizer stripping out right align style for tables
Some BBCode is unimplemented: [email]
, [url]
, [code]
and [img]
Somelink - just another link on the internet fails cause of the tag/category plugin
Mention after paragraph is strange
Can add any oneboxes after an IMG tag
:email, class_name: is not an emoji
https://medium.com/@nicksantos not autolinked
New features
Issues that will not be fixed
This topic is wiki, if you are TL3 or above feel free to clean it up.
32 Likes
Falco
(Falco)
June 26, 2017, 8:36pm
6
Tom_Newsom:
When you have a spare 5 seconds please add table support
Wikipedia Table (converted to markdown)
Name
Programming language
License
bbPress
PHP[2]
GPL[3]
Beehive Forum
PHP
GPL
Discourse
Ruby, JavaScript
GPL
Discuz!
PHP
Discuz! EULA
eXo Platform
Java
LGPL
FluxBB
PHP
GPL
FUDforum
PHP
GPL
Ikonboard
Perl
Proprietary
Invision Power Board
PHP
Proprietary
MyBB
PHP
LGPL, moving to BSD in 2.0[14]
Phorum
PHP
Phorum License 2 (BSD like)
PHPWind
PHP
PHPWind EULA
phpBB
PHP
GPL
PunBB
PHP
GPL
Simple Machines
PHP
BSD License
Syndie
Java
Open source, multiple licenses
UBB.threads
PHP
Proprietary
Vanilla Forums
PHP
Proprietary/GPL[24]
vBulletin
PHP[27]
Proprietary[28]
Thredded
Ruby
MIT
It’s working
25 Likes
elijah
(Eli the Bearded)
June 27, 2017, 5:25am
7
Nesting code fences demo:
Here's how to make a code block in markdown:
```cpp
int main(int argc, char** argv) {
return 0;
```
And here’s how it’s coded:
````markdown
Here's how to make a code block in markdown:
```cpp
int main(int argc, char** argv) {
return 0;
```
````
To nest code blocks with a ```
codefence, just keep making outer codefences longer.
Will it nest to arbitrary depths? Six backtick version:
`````text
````markdown
Here's how to make a code block in markdown:
```cpp
int main(int argc, char** argv) {
return 0;
```
````
`````
And SEVEN!
``````text
`````text
````markdown
Here's how to make a code block in markdown:
```cpp
int main(int argc, char** argv) {
return 0;
```
````
`````
``````
This is the feature I’ve wanted for quoting things in “how to post in Discourse” messages.
7 Likes
dax
(Daniela)
June 27, 2017, 9:12am
8
I have difficult when I need to insert some code in a post.
It seems that [code][/code]
and <pre></pre>
no longer work.
Will it be permanent or simply have not been implemented yet?
Let’s see
<pre><code>int main(int argc, char** argv) {
return 0;
</code></pre>
int main(int argc, char** argv) {
return 0;
dax
(Daniela)
June 27, 2017, 9:43am
10
On my forum if I insert <pre><code> </code></pre>
I 've this result:
and this is the result when I use only <pre></pre>
or <code></code>
So when commonMark will be fully implemented we need to use only <pre><code> </code></pre>
?
1 Like
sam
(Sam Saffron)
June 27, 2017, 2:31pm
15
Fixed a bunch of edge cases with quoting and bbcode blocks
quote after a list
Fixed a bunch of edge cases with quoting and bbcode blocks
[quote]
nested
[quote]
test
[/quote]
[/quote]
quote after a list
- list
[quote]
test
[/quote]
committed 02:07PM - 27 Jun 17 UTC
10 Likes
sam
(Sam Saffron)
June 27, 2017, 3:37pm
17
Nothing really changed with <pre>
or <code>
both work exactly as they used to …
I am pre-formatted
text
<pre>
I am pre-formatted
text
</pre>
It used to work and continues to work.
1 Like
elijah
(Eli the Bearded)
June 27, 2017, 4:17pm
18
Is there a way to disable a onebox and just show a link? Previously leading whitespace did that, but now that doesn’t seem to work.
vv two spaces
https://github.com/discourse/discourse/tree/master/app/mailers
Shows as
https://github.com/discourse/discourse/tree/master/app/mailers
I did manage to disable with the ugly:
https://github.com/discourse/discourse/tree/master/app/mailers
https://github.com/discourse/discourse/tree/master/app/mailers
But that’s not so easy to type.
8 Likes
sam
(Sam Saffron)
June 27, 2017, 4:51pm
19
It is a bug will fix
It may take a day or so cause I need some guidance on the best approach to fix it from @Vitaly
https://github.com/markdown-it/markdown-it/issues/375
5 Likes
Vitaly
June 27, 2017, 7:11pm
20
Seems i did not understood your question on github, sorry. Now got what you asked about.
I see 2 possible workarounds “in spirit of markdown”
Define link text explicit (because such links should not be autoreplaced).
Use <http://...>
autolink (wrap with <...>
)
Easy, but user may wish to use it in very rage case when linkifier fails, to define link borders right. In this case such link will not be oneboxed.
Let me know if that is acceptable. Implementation should be simple - just test more link_open
token attributes.
4 Likes
sam
(Sam Saffron)
June 27, 2017, 7:17pm
21
Trouble is that users have already been trained for a very long time that
space http://somelink.com
does not get a onebox.
and
http://somelink.com
does get a onebox.
It is going to be super painful to teach everyone another option here.
2 Likes
Vitaly
June 27, 2017, 7:42pm
22
I understand :(. Sometime we should do horrible things, because users are not going to change their habits.
Then try patched paragraph rule (which stores info about trimmed head), as discussed on github. The only disadvantage is - it may be changed in upstream on CM spec update. But you can add test to signal about such change.
3 Likes
Sean_R
(Republic Wireless)
June 27, 2017, 8:43pm
24
I wish it showed properly in the preview so I do not have to post this as a topic.
1 Like
sam
(Sam Saffron)
June 27, 2017, 8:52pm
25
That is a bug, we will get it fixed!
8 Likes
sam
(Sam Saffron)
June 27, 2017, 9:02pm
26
The oneboxing issue is fixed:
https://github.com/discourse/discourse/commit/0d62420cbe443b2cf1061405f83f34eef5103532
https://github.com/discourse/discourse/commit/0d62420cbe443b2cf1061405f83f34eef5103532
https://github.com/discourse/discourse/commit/0d62420cbe443b2cf1061405f83f34eef5103532
I did want to take a few moments to say to @Vitaly , it is absolutely amazing one can replace core behavior of the new engine in a very tidy and maintainable way without needing to fork the project. I am able to achieve in minutes stuff that used to take me hours when working with the previous Markdown engines.
The pipeline, date flow and token stream make for an amazingly clear design that is understandable by humans. Thank you.
14 Likes
sam
(Sam Saffron)
June 27, 2017, 9:14pm
27
I enabled the typographer here (with the site setting enable_markdown_typographer
)
This means that:
(c) (C) (r) (R) (tm) (TM) (p) (P) +-
test.. test... test..... test?..... test!....
!!!!!! ???? ,, -- ---
"Smartypants, double quotes" and 'single quotes'
renders as:
© © ® ® ™ ™ § § ±
test… test… test… test?.. test!..
!!! ??? , – —
“Smartypants, double quotes” and ‘single quotes’
I do not think we will enable it by default, but some communities have expressed interest in it so … here you go…
13 Likes
sam
(Sam Saffron)
June 27, 2017, 9:28pm
28
4 Likes