Composer appears when the topic is closed


#1

Hello., I was reading about the new release: Discourse 1.9.0.beta16 Release Notes (:clap:) and I tried to post a new reply there… and found something strange.

Try it now… if you press SHIFT + R to open the composer to enter a reply, the composer will appear even the topic is closed! :bug:

I’m not sure if this is a bug, or not.

Can you check?


Related Reply to Closed Topic thanks to Needs Approval and Keyboard Shortcuts


Composer shortcut should be disabled if user isn't allowed to post
(Joshua Rosenfeld) #2

I’ll need to set up a non-admin account to test. In the meantime, can you confirm if you’re able to post? What happens if you type a valid (>20 character reply) and try to post it?


#3

I tried right now, and it says:

Something has gone wrong. Perhaps this topic was closed or deleted while you were looking at it?

Of course could not post it. :frowning:

Screenshot:


#4

So it’s prob fair to say that it’s not a bug then? Or would you expect the composer not to appear and the modal to come up at the point that you hit the shortcut?


(Joshua Rosenfeld) #5

The composer should not come up at all. We disable the UX elements to launch the composer, keyboard shortcuts should fail too. Going to recategorize this as #ux. Should be fixed, but given that you cannot post it’s low priority.

BTW, I just tested and can repro this.


(Joshua Rosenfeld) #6

@SidV looks like this is a bigger issue than just closed topics. Going to close and link to Composer shortcut should be disabled if user isn't allowed to post.


(Joshua Rosenfeld) #7

Please see