Conflicts with Discourse and 1Password 7 Beta in Safari

feature
11

Hi everyone! :wave:

Jarek here from the 1Password extensions team. I spent a bit of time this morning poking around the Discourse trial instance @osioke got set up for us (thanks for that!), and here are my findings.

I took a look at this particular field and it looks like we’re not showing up anymore as of the latest 1Password X stable version. I added a test case internally to make sure we don’t show up here ever again! :smile:

I confirmed that we were showing up here, and I’ve added a test case internally and made a change that will prevent that from happening (based on the fact that the label above the field mentions “invite”). Whenever the next 1Password X beta is released, give it a try here :slightly_smiling_face:.

I found a field at the following URL that I unfortunately can’t do anything about on our end (admin/users/list/active route):

Screen Shot 2020-09-01 at 10.50.44 AM

Our script to collect information about the page is gathering the following information for this field:

{
    "htmlId": "ember921",
    "htmlClass": "ember-text-field ember-view",
    "isActive": true,
    "opid": 5,
    "placeholder": "username, email or IP address",
    "type": "text",
    "labelBefore": "Show Emails"
},

There’s nothing here that I can target to help 1Password understand not to show up in this field. For all it knows, this could be a login that needs auto-filled.

There are a couple things you folks can do to help 1Password out here. First, you can use the autocomplete="off" attribute. We recently rolled out a new strategy for how we attempt to follow this attribute’s intent, and if this field were autocomplete="off", the menu options beneath the field would be hidden by default and the UX would be vastly improved.

I understand that due to some decisions the Chrome team has made this is difficult for you to do; we have internally discussed treating something like autocomplete="discourse" the same as autocomplete="off", and while I can’t promise anything at the current time I can say it’s on our minds.

There’s something even better that you can do, though. In order to get 1Password to ignore this field altogether we’ll need to indicate that this field is intended for searching and not for logging in. You can do that by giving the field a name="user-search" attribute (or id="user-search"). 1Password will see the search at the end of the name or ID and avoid suggesting logins for that field.

Here’s what the field would look like with that change:

Imgur

1Password would no longer make any suggestions for that field. This is a change you can make to any such search-y fields today to prevent 1Password from showing up! :smile:

I also noticed an “email address to test” field at the admin/email route that would benefit greatly from usage of autocomplete="off".

Those are the issues I noticed. If I missed anything please let me know. Happy to continue to discuss things here! We’re always working on improving suggestions and becoming more accurate about when we do and do not show up.

12 Likes