😿 Emoji's in title shown as code on initial load of a topic page

Bug
1

Steps to Reproduce

  1. Load meta.discourse.org (Refresh)

  2. Click on any topic with an emoji in the title

  3. Look at the tab title – emoji as code

Note: Reloading content via XHR sets the emoji correctly. It is only with a fresh load that the emoji code appears (e.g. from clicking on a notification link jumping directly to a topic).

3 Likes
2

Is this related to your recent title fix @sam?

4

Yeah something is off… bumps

4 Likes
6

This is fixed per:

https://github.com/discourse/discourse/commit/081959227de72c7473d36618bb02ddea3e42ebcd

Note to @team this also adds proper support for String#match? which is available in 2.4 Ruby and backported to 2.3, be sure to use that when checking if a string matches a regex, it is faster than =~ cause it does not need to keep track of a pile of globals.

12 Likes
7

This topic was automatically closed after 26 hours. New replies are no longer allowed.