Custom flag not showing text

bug
1

Received flag does not show user entered text reason. This makes it difficult to moderate posts as moderators have to Pm the user to see why the flag was submitted.

Steps to Reproduce:

  • User flags a post.
  • Flag is sent to moderators/staff.

Expected Results:

  • Flag is shown with user entered custom text

Actual Results:

  • Flag is shown as custom but no reason is displayed even though the user entered one.
1 Like
2

Shows up fine for me on https://try.discourse.org when flagging with a custom reason. Is your Discourse out of date? What version is it?

image
image.png897Ă—353 40.6 KB

3

The header shows - Discourse 1.9.0.beta16.

4

Just to add, it’s IFC Chris is talking about (community.infinite-flight.com). :slight_smile:

Also heard from a user that nothing shows up in their “Sent”-box as it usually does when flagging custom. Haven’t checked this myself yet though.

1 Like
5

And i just noticed, we last received a flag notification in the Moderators inbox three days ago.

6

Did some more testing. If a moderator flags, then the text shows. But if a normal user does it then no text appears.

1 Like
7

Ok can you repro @jomaxro?

8

I think I saw this on Friday cc @hawk. Will test tomorrow.

10

Was able to test tonight. I cannot reproduce a missing message from a custom flag on a post or a topic. I did see this on Friday (see below), but did not get to test it then.

image
image1144Ă—279 10.9 KB

Edit: Oh! I see that it needs to be a non-staff user flagging. Let me retest.

Edit 2: OK, I can repro this when flagging a post with a non-staff (TL1) user. Recategorizing this as a #bug.

6 Likes
11

This one is for you @eviltrout

1 Like
14

This is being caused by this security fix. When attaching a note to a flag it invites groups to view it, and as a regular user you can no longer do this. Re-assigning this to @tgxworld since it’s related to a security fix that I don’t want to break.

10 Likes
15

Fixed in

https://github.com/discourse/discourse/commit/b39d3a863ded81ff4dcc15caf3e55b087f8c3566

with tests.

When I pushed the security fix out, I made sure to update the moderators group’s messageable level to everyone but I didn’t do it right xD

5 Likes
16

Is the fix live now? We’re still having the issue on devforum.roblox.com

17

Not yet. We’ll be deploying our customers shortly once the build is complete.

4 Likes
18

Pushed up another fix which was the reason why we got bitten here.

https://github.com/discourse/discourse/commit/30ddc1f2226df0e6b553cc96de2f4f6543e42b57

5 Likes
19

I know it’s Christmas time and all that fun, but just checking up on this one. Any news on when it will be deployed?

Thanks! :slight_smile:

20

Pretty sure this was already deployed to our hosted customers. Which site are you referring to specifically?

21

It’s for:

Just had a custom flag a few minutes ago, still the same. And we’re not getting anything in the Moderator inbox.

Just got this:

image
image.png817Ă—223 12.7 KB

1 Like
22

OK @tgxworld be sure to deploy that site when you get a chance.

4 Likes
23

Deployed :slight_smile:

3 Likes