Custom Hamburger Menu Links

Canapin · November 8, 2022, 12:53am

I took a look at Discourse’s sidebar code and @nolo icons addition.

It seems that currently, it’s not possible to customize the icon’s custom links because the hamburger menu decoration method doesn’t take into account the prefixValue constant (which contains the icon’s name) or something like that…

It also seems to me that hamburger-menu decorations with api.decorateWidget are going to be depreciated. See:

github.com

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/lib/plugin-api.js#L534


      
                      // Skip external links support for now
                      return;
                    }
                  } else {
                    args.route = route;
                  }
          
          
        this.addCommunitySectionLink(args, name.match(/footerLinks/));
                } catch {
                  deprecated(
                    `Usage of \`api.decorateWidget('hamburger-menu:generalLinks')\` is incompatible with the \`enable_experimental_sidebar_hamburger\` site setting. Please use \`api.addCommunitySectionLink\` instead.`
                  );
                }
          
          
      return;
              }
            }
          }
          
          
/**
           * Adds a new action to a widget that already exists. You can use this to

Also, the fact that external links don’t work anymore could come from this:

github.com

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/lib/plugin-api.js#L524


      
            const args = {
              name: className || textContent.replace(/\s+/g, "-").toLowerCase(),
              title: textContent,
              text: textContent,
            };
          
          
  if (href) {
              if (DiscourseURL.isInternal(href)) {
                args.href = href;
              } else {
                // Skip external links support for now
                return;
              }
            } else {
              args.route = route;
            }
          
          
  this.addCommunitySectionLink(args, name.match(/footerLinks/));
          } catch {
            deprecated(
              `Usage of \`api.decorateWidget('hamburger-menu:generalLinks')\` is incompatible with the \`enable_experimental_sidebar_hamburger\` site setting. Please use \`api.addCommunitySectionLink\` instead.`

So that there should be some changes in core to make this available.

My knowledge of how Discourse works is almost non-existent so I could be very wrong.

Am I right about my findings?

Topic		Replies	Views
Ability to add a custom section of links to the sidebar Feature sidebar , completed	15	3597	February 18, 2023
Header Submenus Theme component official , header-submenus	87	36133	November 14, 2024
Custom Header Links Theme component official , custom-header-links	45	49209	July 1, 2024
Removing the legacy hamburger navigation menu option Announcements	43	4167	October 8, 2023
Right Sidebar Blocks Theme component official , desktop , right-sidebar-blocks	100	10963	December 9, 2024

Custom Hamburger Menu Links

Related topics