Custom header icons disproportionate to core header icons

Hey there, just updated discourse to the latest version: 3.3.0.beta1 (48cb7b7863)

And noticed that the header icons have been made smaller by default.
Which means that the icons from this component are now “larger” compared to them.

image

I identified the issue as some classes missing from the component header icons.

This is the html for the component icons:

And this is the html for the discourse icons:

image

I tested editing the html directly from the developer console and if we add btn no-text the styles matches again.

image

I’ll try and open a PR request for the component but thought to raise the issue here as there isn’t an issue tab in the github repository.


PR Created: update html template to align with change in style from discourse header icons by theCrius · Pull Request #23 · discourse/discourse-icon-header-links · GitHub

2 Likes

Any update on this?

2 Likes

I have merged your PR, thanks a bunch!

3 Likes

This topic was automatically closed after 2 days. New replies are no longer allowed.