Custom Layouts Plugin

(Angus McLeod) #5

Great! I’m just in transit at the moment. I’ll check it out when I get back home next week.

And provide an example instance @trash

1 Like

(Angus McLeod) #6

You can now see this plugin in action, along with my other plugins at: https://dev.civll.com/

5 Likes

#7

Great idea for a widget, I tried it on a test server (with a heavily modified Discourse) but I had a failed to bootstrap, is it working on yours still ?

The profile widget worked well during install.

0 Likes

(Angus McLeod) #8

@jez Thanks again for making a widget that works with Custom Layouts. I’ve submitted a PR to your widget repo to fix the issue @Steven mentions.

2 Likes

(SMHassanAlavi) #9

@angus
Thanks for you plugin.
I have some question about your widget.
in your profile widget there is some lines :

h('h3', this.attach('link', {
            route: 'user',
            model: currentUser,
            className: 'user-activity-link',
            icon: 'user',
            rawLabel: username
          }))

or

this.attach('button', {
          label: "sign_up",
          className: 'btn-primary sign-up-button',
          action: "sendShowCreateAccount"
        })

I know what these codes do but I don’t know where how to modify these codes.
for example I want to add a create topic button to widget but I don’t know how should I change
this code:

this.attach('button', {
          label: "sign_up",
          className: 'btn-primary sign-up-button',
          action: "sendShowCreateAccount"
        })

I know what is className(used for CSS) and label and rawLabel(used for translation)(if I am wrong please tell me) but I don’t know where should I find all other actions for button and icons.
I have another question,
In this code:

h('h3', this.attach('link', {
            route: 'user',
            model: currentUser,
            className: 'user-activity-link',
            icon: 'user',
            rawLabel: username
          }))

what does the route and model do?what is link?
Last question, in this code:
contents.push("img", "")
how should I config the image source?image is not in my site

0 Likes

(Angus McLeod) #10

Hey @Alavi1412, if I’m understanding you correctly, you want to modify the profile widget to add a button that allows the user to open the composer to create a new topic?

Any button has two basic parts two it: the button element, and the button action. I think you already understand the button element part. As you say you’ll need to use the button widget with the appropriate classes, icon and label (note that the button widget doesn’t have a rawLabel, only a link does - go to the button widget file and search for ‘rawlabel’ and there will be no matches. Yes the ‘label’ requires a translation object). We’ll also need the button action, which refers to a method that handles what happens when the button is clicked.

This is the process I would take to figure out what we need for both the button element and the button action. I suggest you follow these steps yourself, as it will help you understand other issues you’ll encounter.

As always, the place we start is with the existing Discourse functionality we want to copy. In this case we start with the button in normal Discourse that opens the new topic compose when it is clicked.

  1. Go to meta.discourse.org and highlight the Create Topic button with the chrome inspector. You’ll see it has the id create-topic.

  2. Do a search for create-topic in the Discourse code. These are the results you’ll get

    How do we know which results are relevant? There’s often good hints in the name of the files. We know that the ‘Create Topic’ button appears in the same part of the app as the navigation controls, so it seems likely that the files with ‘navigation’ in the path are relevant. Those results also seem to be about button elements, which is what we’re after.

  3. Click through one of those relevant results and you’ll find button elements in templates that give us much of the information we need. e.g.:

    <button id="create-topic" class='btn btn-default' {{action "createTopic"}}><i class='fa fa-plus'></i>{{i18n 'topic.create'}}</button>
    

    We can simply copy / past these details to our button widget like so:

    this.attach('button', {
        className: 'btn btn-default',
        action: 'createTopic',
        label: 'topic.create',
        icon: 'plus'
      })
    

    Once we add that button widget to the profile widget, we now have a create topic button in the profile widget. We’re half the way there.

  4. If you click that new button, you’ll see a message in the console createTopic not found. We need to deal with the second part of the button, the button action. If you’ve read the part of the Ember Guide that covers Template Actions, you’ll know that the action handler we got from one of those templates refers to an action method in a corresponding component, controller or route. So let’s just do a search for that handler and find the corresponding instance.

    The search for createTopic will produce many results. It is useful to know that the part of the app with topic lists is called ‘discovery’. Also keep in mind that we’re looking for a method; any of the results are not methods. Scanning the results list the first one that really jumps out at me is this one (it’s both a method and it seems to be in the right place in the code:

    If you click through that result you’ll see a method like this:

    createTopic() {
      this.openComposer(this.controllerFor("discovery/topics"));
    },
    
  5. Ok we’ve now found the method. How do we get that method to work for our widget button? If you’ve read A tour of how the Widget (Virtual DOM) code in Discourse works, you’ll know that each action in a widget needs a corresponding action handler in the widget. Ok, so let’s create a createTopic method in the profile widget that does the same thing the createTopic method in the Discovery Route does.

    If you follow where the openComposer method in createTopic in the Discovery Route comes from (or open any of the other results in our search for createTopic methods in the codebase) you’ll figure you that what we need to do is send an ‘open’ action to the composer controller with the right parameters.

    this.controllerFor('composer').open({
      categoryId: controller.get('category.id'),
      action: Composer.CREATE_TOPIC,
      draftKey: controller.get('model.draft_key'),
      draftSequence: controller.get('model.draft_sequence')
    });
    

    So we need to access the composer controller in our widget action. The createTopic method in the discovery route also uses the discovery/topics controller, so we’ll need that too. If you look at the other action handlers in the profile widget you’ll see how they access controllers and routes from the widget. i.e.

    const cController = this.register.lookup('controller:composer');
    const dtController = this.register.lookup('controller:discovery/topics');
    

    Using this approach we can now make our own createTopic method.

      createTopic() {
        const cController = this.register.lookup('controller:composer');
        const dtController = this.register.lookup('controller:discovery/topics');
        cController.open({
          categoryId: dtController.get('category.id'),
          action: Composer.CREATE_TOPIC,
          draftKey: dtController.get('model.draft_key'),
          draftSequence: dtController.get('model.draft_sequence')
        });
      },
    

    The only part we’re missing now is the Composer object. That’s a reference to the composer model. All we need to do for that is import the composer model. Add the import at the top of the profile widget file

    import Composer from 'discourse/models/composer';
    

Once you add that new createTopic method and reload, your Create Topic button will now (mostly) work like the Create Topic button in the normal Discourse discovery. The composer will open. There are some issues that arise by virtue of the fact that the profile widget can appear in different contexts from the context in which the normal Create Topic button appears.

There are other ways to do the same thing we just did, however the key point here is:

  1. Start with what you already know. We know that there is a button in normal Discourse that does what we want to do. Start by figuring out how that works.

  2. Copy as much as possible. We can copy from both normal Discourse and the existing code in the profile widget that does similar things to what we want to do.

Using this approach the answers you get will not be 100% perfect, but they will get you 90% of the way there. Once you’re 90% there you have a much better idea of what the 10% of actual problems you’ll need to figure out are.

I have to get back to work now, so I’ll leave those other questions with you for now. Apply the same approach and see if you can figure out the answers.

7 Likes

(SMHassanAlavi) #11

@angus
Thank you so much.It helps me very well,
but I still have one question.
when our widget become long(longer than browser height), the button part is not shown after scrolling
before scrolling:


after scrolling:

one part of my widget is at the bottom but because of the height it is not shown even after scrolling.
in the other words, I don’t want my widget to float with user,I want to fix the widget in a position

0 Likes

(Angus McLeod) #12

Yup, there’s a setting for that actually. Check Settings > Plugins.

1 Like

(SMHassanAlavi) #13

@angus
Why widget is not shown in categories page like :
http://localhost:3000/c/30
there is a white space in the widgets place but there is no widget

0 Likes

(Angus McLeod) #14

Have you enabled the sidebar on category pages?

You can enable the sidebar either for all category pages in the admin plugin settings or you can enable the sidebar and widgets for specific categories in the category settings.

2 Likes

(SMHassanAlavi) #15

Yes I have done this.but nothing is shown.
this page can define my problem

0 Likes

(Angus McLeod) #16

Ah, you mean the sidebars are not working on the tags index page?

0 Likes

(Angus McLeod) #17

I’ve added sidebar support to the tags show route. Let me know if that solves your issue.

You’ll need to turn sidebars on for the tags route in admin settings

1 Like

(SMHassanAlavi) #18

@angus Thank you for your change but my problem was something else.(apologize for my delay, I was travelling)
I have done every changes you said but I still have this problem:


my widget didn’t show here.
Here is my code.

0 Likes

(Angus McLeod) #19

The problem is that you’re trying to convert the attrs object to a JSON string and it’s failing. This exception is preventing the sidebars from loading on category routes.

Change these lines

alert(path);
alert("state: " + JSON.stringify(state));
alert("attrs: " + JSON.stringify(attrs));

to this

console.log(path);
console.log("state: ", state);
console.log("attrs: ", attrs);

And check the output in your browser console: View > Developer > JavaScript Console

Also, rather than using an ajax call to get your category list, I suggest you use:

const categories = Discourse.Category.list()

Let me know if you need any help with the rest of it.

2 Likes

(SMHassanAlavi) #20

awesome !!!

where should I find something like this?
in writing widget I find the data I need in site and then in XHR of network tab in chrome, I find the url and I use this url in my widget and its response in ajax. but your way is very fast and useful. How can I replace my way of getting data by ajax with something like Discourse.Category.list()

0 Likes

(Angus McLeod) #21

Separate out the logic you currently have inside the success method of the ajax call. And change all the instances of data.category_list.categories to just categories

This

      $.ajax({
          url: "/categories.json",
          dataType: 'json',
          async: false,
          success: function(data) {
            for (var i = 0 ; i < data.category_list.categories.length ; i++) {
...

Will change to this

const categories = Discourse.Category.list()
for (var i = 0 ; i < categories.length ; i++) {
...
2 Likes

(SMHassanAlavi) #22

thank you bot I didn’t mean than.
I mean where should I find a reference of something like Discourse.Category.list(). For example can I get received_likes with just one line code with this?
I have another question, what is the problem with ajax?

0 Likes

(Angus McLeod) #23

Whenever you see the discourse namespace being used in this fashion in the client, it means that the method can be found in the relevant model file. In this case, you will find the Discourse.Category.list() method in the Category model file, here.

You’ll see that that method refers to the property categories on the Site model (Site is a singleton - i.e. there is only ever one instance of it - and the method currentProp is just a method that lets you get a property from a singleton model - see here).

The categories property on the Site model is kept updated from the server by a message bus subscription in an initializer - see here. This subscription subscribes to data on the server when the app initializes and gets updates when the data on the server changes.

When the categories subscription receives data, it updates the categories property on the Site model using the updateCategory method.

The server side of the message bus subscription is here. As you can see, it serializes (i.e. “sends one after another”) the categories (i.e. “self” in the Category model) to the server as JSON.

If you want to see another example of a plugin using the message bus to push data to the client, see here in the topic ratings plugin. That publication pushes ratings data to all clients when one user adds or creates a rating.

You could use your own ajax call in this scenario if you want. However, generally it is a good idea to try and re-use as much existing core discourse infrastructure as possible. You’ll save a lot of time and energy (perhaps not initially but definitely over time), you’ll understand more about how Discourse works and your work will be better able to keep up with changes in the Discourse codebase.

4 Likes

(Angus McLeod) #24

In further response to a question via PM: “How do I get data from the server in a plugin?”

Firstly, before you go trying to get data from the server, check if the data is already available on the client. If its data about the user, a category, a topic list or even a topic, you may already have it on the client and there is no need to add a new call to the server.

Furthermore, if you want extra data about a model you already have on the client, e.g. the user, normally the best way to get that is to add that extra data to the serializer that is already serializing that model to the client. It’s a bit like calling your friend and asking them to pick up something extra from the supermarket while they’re there, rather than going to the supermarket for that one thing yourself. I can elaborate on how to add data to an existing serialization separately.

That said, there are two basic ways to get data from the server in a plugin:

  1. Ajax call. You can call any get route the server already has set up - see the server route file here, or you can create your own get route in a plugin - see here for an example of how to create a new route in a plugin.

  2. Message bus. See previous post for an example of how the message bus works. To see what other message buses you can subscribe to, just do a search for MessageBus in the server code.

If the route or message bus subscription is not already available, you’ll have to create it in your plugin.rb file.

3 Likes