Bumped into the same problem, hoping for a fix soon. Switching dark/light with my local device setting works fine and shows the correct light-logo.
EDIT: I noticed this bug only happens, when the actual device setting is set to dark, if the current device setting is light everything works as expected. Hope this helps.
Due to a refactor & implementation of how dark mode & light mode now work in core, this issue has arisen. It will take a good refactor of the code to get it working properly.
@jordan-vidrine - Any updates?
For some reason my toggle has stopped working all together. Not sure if itās update related or something Iāve done.
Will keep troubleshooting though!
Figured it out!
I mangled my dark mode id and had to set user preferences to match the default on the theme.
That go everything straightened out.
Thank you for the great toggle!
If I am understanding this correctly, the component is designed to swap between two color schemes for a single theme rather than allowing for the selection of a theme itself?
Unfortunately, due to upcoming changes to Discourse Core, this component will no longer be supported. We will work on refactoring the component to eventually be usable in the new Discourse Core user menu, but for now I will mark this component as broken because of the issues that arise when switching from a dark ā light color scheme.
Has anyone found a workaround for this issue? We are still using it on live since itās just a cosmetic issue. And having such a simple dark theme switch overweights the flaw, but still would be nice to fix it
Thanks to @pmusaraj for some amazing updates & refactor to this component. His refactor solved all of the issues that arise when system is set to dark mode & users want to switch their forum UI to light mode.
We have defaulted to not have the toggle be shown in the header menu. This will show it in the footer of Discourseās new sidebar.
If you want to display in the header, you can choose to show it in the header menu via theme settings.
After updating, the toggles from the āoldā menu are completely gone. We are not using the new sidebar yet. And our header bar is already full of multiple other icons so we donāt want to add it there.
Any way to add it back to the bottom of the old menu?
Sorry, there is not as we are now focused on the new user menu & sidebar as the previous hamburger menu will eventually be deprecated.
That being said, you donāt need to enable the docked sidebar to use this feature, but you will need to enable the experimental hamburger menu like so.