Disable_emails: false on restore stopped working

Bug
1

The previously working :disable_emails option in the BackupRestore.restore! function seems not to be passed to BackupRestore::Restorer::initialize any more:

https://github.com/discourse/discourse/blob/master/lib/backup_restore.rb#L19-L27

while https://github.com/discourse/discourse/blob/master/lib/backup_restore/restorer.rb#L12:

def initialize(user_id:, filename:, factory:, disable_emails: true)

So now this option parameter is silently dropped, making it impossible to restore without disabling emails.

Maybe forgotten while refactoring, maybe removed on purpose?

7 Likes
2

Thanks for reporting.

https://github.com/discourse/discourse/commit/5889309d3b7b53bd358937641739956412530487

10 Likes