Disable_emails: false on restore stopped working

RGJ · Março 2, 2020, 4:24pm

The previously working :disable_emails option in the BackupRestore.restore! function seems not to be passed to BackupRestore::Restorer::initialize any more:

github.com/discourse/discourse

lib/backup_restore.rb

main


      
          def self.restore!(user_id, opts = {})
            spawn_process!(:restore, user_id, opts)
          end
          
          def self.rollback!
            raise BackupRestore::OperationRunningError if BackupRestore.is_operation_running?
            move_tables_between_schemas("backup", "public") if can_rollback?
          end

while discourse/lib/backup_restore/restorer.rb at main · discourse/discourse · GitHub

def initialize(user_id:, filename:, factory:, disable_emails: true)

So now this option parameter is silently dropped, making it impossible to restore without disabling emails.

Maybe forgotten while refactoring, maybe removed on purpose?

gerhard · Março 2, 2020, 4:44pm

Thanks for reporting.

Tópico		Respostas	Visualizações
When restoring a backup, the 'disable email' will be set to non-staff from no Bug	9	812	16 de Abril de 2019
All email disabled after restoring backup? Feature	6	916	26 de Fevereiro de 2019
Restored from backup, but email disabled? Support	4	1032	16 de Maio de 2022
How do I re-enable email and logging into my account after restoring backup? Support	9	1489	13 de Dezembro de 2022
Disabling email on backup restore Feature	7	759	8 de Setembro de 2023

Disable_emails: false on restore stopped working

Tópicos relacionados