Ok… but in this case, a non-admin user cannot even see their own name, and has no knowledge that full-names are even a thing on the site. I still cannot imagine a use for double-secret-probation treatment of full-names.
Yes, that is what the description says, but the description does not quite capture what the setting actually does.
…weird under Option #1. It makes perfect sense under Option #2.
PR was merged, and the original bug reported in this topic is fixed.
We can open an additional Feature topic to discuss how the enable_names setting should behave.
This PR only fixed the original bug when the admin could not edit the full name. When SiteSetting.enable_names is disabled, neither moderators nor users will see names. Like you suggested, we might need additional settings for that.