Disappearing "continuing the discussion from" drafts

Contribuer Fonctionnalité
1

Continuing the discussion from Reply as new message to same recipients:

Also found while implementing this feature.

Steps to reproduce:

  1. Open a topic
  2. Click on the date
  3. Click “New Topic”
  4. Start writing a post, wait for it to be saved as a draft
  5. Refresh the page

Result:

Draft disappears

Expected result:

Composer window reopens with draft in it

Bonus buggy fun:

  1. Navigate to a new topic
  2. Click on the date
  3. Click “New Topic”

Result:

Phantom draft :ghost:

Screen Shot 2016-11-10 at 11.15.39.png960×700 78.7 KB

Like the other bug I’ll probably have a shot at fixing this after I submit my PR, although I wouldn’t say I’m particularly confident at my ability to fix it. If no-one hears from me for a few days please send a search party.

3 « J'aime »
Reply as new message to same recipients
2

Errr this is not a bug. This is expected behavior. There is one and exactly one new topic draft available to you at any given time. (compare with literally infinite reply drafts, one per every topic in the system, potentially)

You can get back to it by triggering a new topic creation.

New topic creation is how you get back to your topic draft.

3

The trouble is, “continuing the discussion from” drafts (drafts with draftKey = "reply_as_new_topic") don’t behave as other drafts do, nor as (I think) it should.

Because a picture tells a thousand words, and a thousand words still isn’t enough, this should show what I mean:

4 « J'aime »
4

@codinghorror so you would agree this is a bug, right?

I’ve been trying to figure this out in my head, and I can’t decide, what should the fix here be?

Should reply_as_new_topic drafts be behave like reply drafts - because they’re replies - or like new topic drafts - because they’re new topics?

I think they should probably behave more like reply drafts - unique to a topic, and reopening when you navigate back to it.

5

I think it is a very rare bug for people to actually run into. Would be quite low on my priority list.

6

Hi Leo! Personally I am with @codinghorror on this issue. It can behave the same way as all new messages. I do think someday someone should create a drafts folder and system for managing and limiting drafts (it’s clunky to not be able to keep a few drafts going whether new or reply) but it’s not a pressing issue.

2 « J'aime »
7

Devinez quoi … des années plus tard … j’ai corrigé cela.

Il y a maintenant une grande cohérence des brouillons : si vous répondez dans un nouveau sujet, la clé de brouillon du sujet en cours est utilisée, ce qui vous permet de revenir facilement soit depuis les « brouillons », soit en visitant le sujet.

Nous avions des clés fantômes jusqu’il y a deux semaines :crying_cat_face:

9 « J'aime »
8

Ce sujet a été automatiquement fermé après 3 jours. De nouvelles réponses ne sont plus autorisées.