O0of_Fo0O
(O0of Fo0O)
21 ืืืื,โ 2020,โ 4:53pm
1
So, when i was ranked to member, i decided to modify my settings. Because iโm french, i set the language the french. I decided to do the advanced tutorial but when i did @discobot in Private Message It was like that:
(Means Hi! To see what i can do, do
@discobot )
But i already did it. So after 1 hour i decided to come back in english andโฆ IT WORKED :
(Cโant Put more than more images )
Soโฆ Yea it pretty much it
I hope it fixed,
d3vlopper
2 ืืืืงืื
JimPas
22 ืืืื,โ 2020,โ 7:13pm
3
For the Advanced tutorial, you can type this @discobot start advanced tutorial .
I donโt know how to translate that to French. Sorry.
ืืืืง 1
Benjamin_D
(Benjamin Decotte)
12 ืืืื ื,โ 2020,โ 10:33am
5
ืืืืง 1
discobot
(discobot)
12 ืืืื ื,โ 2020,โ 10:33am
6
Hi! To find out what I can do, say @discobot display help.
Benjamin_D
(Benjamin Decotte)
12 ืืืื ื,โ 2020,โ 10:38am
7
discobot:
@discobot display help .
En franรงais :
@discobot afficher l'aide
ืืืืง 1
Benjamin_D
(Benjamin Decotte)
12 ืืืื ื,โ 2020,โ 10:40am
8
that said, in French, @discobot afficher l'aide suggests to call @discobot and @discobot alone doesnโt trigger anything
Hi @neil , I think line 123 of https://github.com/discourse/discourse/blob/master/plugins/discourse-narrative-bot/config/locales/server.fr.yml ,
Bonjour ! Pour voir ce que je peux faire, dites @%{discobot_username} .
should be
Bonjour ! Pour voir ce que je peux faire, dites @%{discobot_username} %{help_trigger}.
4 ืืืืงืื
neil
(Neil Lalonde)
15 ืืืื ื,โ 2020,โ 2:52pm
9
Yes looks like a bad translation. It needs to be fixed in Transifex (soon CrowdIn) though. Relevant discussion:
Lots of fixes and changes were included in the last 2 or 3 beta versions. Let me know if you find an issue or a change that you disagree with.
This is the main challenge. I would say the best is to stick with the glossary and existing translations, even if we donโt fully agree with them. Just like developers should follow the coding style of the project they just joined.
However, Transifex is not helping here: its โSuggestionsโ tab is showing old or deleted translations that are no longer relโฆ
4 ืืืืงืื
zogstrip
15 ืืืื ื,โ 2020,โ 3:05pm
10
Thanks @Benjamin_D , I just fixed the translation on transifex
3 ืืืืงืื
Benjamin_D
(Benjamin Decotte)
25 ืืืื ื,โ 2020,โ 2:49am
11
I found a new one
@discobot afficher l'aide doesnโt trigger the help and then neither gives the tracks
it is probably because of the โ ,
removing it from discourse_narrative_bot.track_selector.help_trigger solves it
2 ืืืืงืื
zogstrip
25 ืืืื ื,โ 2020,โ 11:35am
12
I fixed the code that was matching the content of the post with the triggers since there was a difference between the raw and cooked versions of the trigger (eg. the ' is cooked into โ)
committed 11:29AM - 25 Jun 20 UTC
In French, the help trigger has a raw content of "afficher l'aider" which is theโฆ n cooked into "afficher lโaide" (note the different quote character).
Since we were checking the raw content of the trigger against the cooked version of the post, this trigger never worked in French.
This changes so that we cook the trigger before checking in against the cooked version of the post.
DEV: new 'discobot_username' method that is used everywhere instead of 'discobot_user.username' / 'discobot_user.username_lower'
4 ืืืืงืื