New users seeing this : translation missing: en.discourse_narrative_bot.new_user_narrative.hello.message If you’d like to learn more, select below and bookmark this private message. If you do, there may be a :gift: in your future! My current template is : Thanks for joining %{site_name}, and …

Yes, site is in english. Running latest version v1.9.0.beta2 +7. I upgraded this morning.

FIXED I changed %{site_name}, to %{title}, and confirmed it by creating a new account. Thanks.

Hmm should this say “translation missing”? The error seems to be Thanks for joining %{site_name}, and welcome! versus Thanks for joining %{title}, and welcome! Perhaps a better result would be translation error: en.discourse_narrative_bot.new_user_narrative.hello.message is that possible…

That is the message returned by the i18n gem when the given parameters do not match the expected parameters in the translation string. If we want to change the message we’ll have to propose it to the gem which might not be worth the trouble. Instead, I’m more inclined to fix the root cause here by a…

I think the upstream fix is superior in this case and would help more folks, bad error messages are very very dangerous.

I don’t think the message is incorrect here. What is happening here is that the user is asking for a translation string that takes in the site_name params which isn’t defined so translation missing is correct here IMO.

I don’t agree. The translation is looking for key value pairs, the substitutions are at best optional parameters. In this case the translation is present according to the key value pair but missing parameters. It is a very misleading error message… if it’s too hard to fix right, then so be it I gue…

Is there any chance that these translation missing errors could also trigger a warning message to staff? In the case of emails, it might be best to suppress emails containing an error message as proposed here: [image] "translation missing" being delivered via email Bug …

[image] codinghorror: the substitutions are at best optional parameters. The substitutions are not optional in the case of translation strings with params. [image] codinghorror: if it’s too hard to fix right I don’t necessary think it should be called an error but I do think that tran…

Yes translation data missing works much better than translation missing! The messages need to be significantly different.

Discobot translation missing error

Soutien

jomaxro (Joshua Rosenfeld) Août 25, 2017, 12:33 20

I saw that suggestion here, which is marked as a solution by the OP so I’m assuming it works. (Emphasis on assume)

Sujet		Réponses	Vues
Errors after migrating to a new version (1.9.0.beta3) Bug	14	2039	Juillet 11, 2017
Email invitation Failed (due to translation issue since 1.4.0.beta7 update?) Bug	7	1851	Septembre 11, 2015
How to fix translation errors Bug	30	2653	Juin 20, 2017
"translation missing" error after changing text content Support	9	3287	Mars 3, 2017
Text "login_required.welcome_message": The following interpolation key(s) are missing: "title" Support	8	1356	Octobre 21, 2017

Discobot translation missing error

Sujets connexes