Discourse-jitsi component not working

ranjeet · January 8, 2024, 1:03pm

I have install the discourse-jitsi
but no option is available in the editor to add jitsi conference

Arkshine · January 8, 2024, 1:46pm

There is an error:

[THEME 81 ‘Discourse Jitsi’] Compile error: SyntaxError: “/discourse/theme-81/discourse/components/modal/insert-jitsi: Identifier ‘themePrefix’ has already been declared. (11:7)\n\n 9 | import DModal from "discourse/components/d-modal";\n 10 | import TextField from "discourse/components/text-field";\n> 11 | import themePrefix from "discourse/helpers/theme-prefix";\n | ^\n 12 | import i18n from "discourse-common/helpers/i18n";\n 13 | export default class InsertJitsi extends Component {\n 14 | @tracked” (discourse/components/modal/insert-jitsi.gjs)

themePrefix function is already available in a component context, and the error happens because the import tries to overwrite that. This is related to the latest PR #20.

github.com

discourse/discourse-jitsi/blob/main/javascripts/discourse/components/modal/insert-jitsi.gjs#L8


      
          import Component from "@glimmer/component";
          import { tracked } from "@glimmer/tracking";
          import { Input } from "@ember/component";
          import { action } from "@ember/object";
          import DButton from "discourse/components/d-button";
          import DModal from "discourse/components/d-modal";
          import TextField from "discourse/components/text-field";
          import themePrefix from "discourse/helpers/theme-prefix";
          import i18n from "discourse-common/helpers/i18n";
          
          export default class InsertJitsi extends Component {
            @tracked mobileIframe = true;
            @tracked desktopIframe = true;
            @tracked jitsiRoom = "";
            @tracked buttonText = "";
          
            keyDown(e) {
              if (e.keyCode === 13) {

EDIT: made a PR

github.com/discourse/discourse-jitsi

FIX: Syntax and settings issues

discourse:main ← Arkshine:fix-import-and-settings

opened 03:18PM - 08 Jan 24 UTC

Arkshine

+1 -4

Meta: https://meta.discourse.org/t/discourse-jitsi-component-not-working/290861 … Followup https://github.com/discourse/discourse-jitsi/pull/20 This PR fixes two issues: * `Identifier ‘themePrefix’ has already been declared`; `themePrefix` function already exists in a component context. * The theme settings are not working because the site settings lookup overwrote them. There is also a logic issue with the `show_in_options_dropdown` setting, where we want to show the button if `only_available_to_staff` is not checked or the user is a staff only. Tests would be welcomed, but I'm not good enough yet to make them correctly and fast.

JammyDodger · January 8, 2024, 3:04pm

As it’s an official theme component (especially one with a tag set up ) having a dedicated topic is . It saves me having to split topics off later.

merefield · January 8, 2024, 3:06pm

Ah, great! Good to hear!

pmusaraj · January 8, 2024, 8:06pm

Thanks so much for the fix, @Arkshine, it is now merged.

isaac · January 8, 2024, 8:18pm

Thanks @Arkshine, are we good to close this off?

pmusaraj · January 10, 2024, 11:03pm

This topic was automatically closed after 2 days. New replies are no longer allowed.

Topic		Replies	Views
Where should we ask help? site feedback	5	313	January 8, 2024
Putting a button into Chat for Jitsi calls feature chat , jitsi-video	4	642	February 28, 2024
Jitsi Video Conference theme-component official , jitsi-video	58	10201	January 23, 2024
Upcoming theme components 'use strict' change - themes break after upgrading Discourse support	17	1204	April 13, 2021
Whereby Video Meetings theme-component end-of-life	8	2275	January 19, 2024

Discourse-jitsi component not working

Related Topics