Retours Discourse

[mcdanlj (Michael K Johnson)]

@wolftune

Unfortunately, the official plugin cannot be a full replacement. It’s missing the ability to post multiple reactions!

Members at Maker Forums definitely appreciate the ability to have multiple emoji reactions. We would be very sad to lose that in a migration if retort were to become unmaintained.

[angus (Angus McLeod)]

Retort will continue to be maintained by Pavilion.

@angus

Also in light of that, I’ll maintain this plugin as is for the foreseeable future, as that’s a substantive difference. The migration will still be useful to a plurality of users I think though.

@Ahmed_Gagan Any thoughts on the below?

@angus

It’s possible that a user could have both liked and “retorted” on a post. In the migration, I’m going to preference retorts over likes in this scenario. However the ReactionManager.toggle! access protections do not allow this.

Would it be possible to add a “force” option for migrations? Or could you suggest another approach?

[Ahmed_Gagan]

For a retort reaction at priority you can use

SiteSetting.post_undo_action_window_mins =max allowed minutes


ReactionManager.new(first_retort_reaction_at_priority, by_user, Guardian.new(by_user), post).toggle!

This will handle everything, it will remove like if the user have already liked the post and add a reaction.

[angus (Angus McLeod)]

Yup, I could do that. It would be a bit of a hack though

I’m not sure I could assume that workaround would remain viable over time. It’s also a bit risky. For example, if I just run that code the user’s post_undo_action_window_mins site setting would remained changed. You could change it back at the end of the migration, but doing setting changes like this on the fly to get around a guardian is not ideal.

Ideally what I’m after here is a slight change to the ReactionManager interface to make it possible to reliably migrate retorts to reactions. Currently it’s only set up to handle requests from the client.

One way to do that would be to

• abstract the guardian in toggle! to an ensure_can_toggle method
• make the ensure_can_toggle method subject to a force option

This is the approach typically taken to handle migrations or backend imports in other parts of Discourse (if you do a search in app/ or lib/ for force you’ll see a few examples).

Does that make sense?

[Ahmed_Gagan]

I think we don’t need to use the setting here, As we are not touching the likes which are already created on the post. this means we are creating new reactions to post. in this case guardian.can_delete_reaction_user? will always be true. Just using ReactionManager.toggle will be enough for this purpose IMO.

[debryc (Deborah Chang)]

Discourse does a lot with Likes such as limiting number of Likes by trust level and giving people badges based on Likes.

Does adding a reaction also add to the Likes count for both users and topics?

[wolftune]

You coud ask separately about how this interacts with the new official Discourse Reactions - Beyond Likes plugin

But Retort (which allows multiple reactions per post per user, unlike the Discourse Reactions plugin) does not interact at all with the Likes-related trust levels and badges.

[omano]

@gdpelican this is a repost from Reaction emoji seem to have no verification as it seems the reaction is not part of discourse I repost it here:

I think I have discovered a bug but I don’t have a proper reproduction, but I can easily show examples of the issue, and I think my theory might be right.

Here is the issue, you are able to add non existent emoji to the post reactions. it results in :whateverYouWant: reactions in posts.

You can see example of it on the Manjaro forum, where I noticed a specific user posts often have these non existent emojis. After asking him a few questions I concluded he’s using some kind of automatic translation extension in his browser, and that probably translates the emojis :code: to his language. Unfortunately I didn’t have a reply from this user to know exactly his setup on his browser. To back my theory, you can see when he quoted someone in the following thread linked, he had translation of the original message in his quote.

See this message/thread on Manjaro forum:

Who is the maintainer of the manjaro community edition LXQt?

See an example in the reactions, you see the issue clearly with all the proper reactions next to the invalid one:

Volunteers needed

So it seems that a user can send non existent emojis through the process of no verification of the emoji code.

[th21]

Did anyone also run into this situation that the reactions misplaced on a small screen and on mobile?

[angus (Angus McLeod)]

I’ve updated this plugin to work with the latest discourse code.

https://github.com/gdpelican/retort/commit/2b94ca394e941342cba4a4ee4950daf54856fa61

@th21 I’ve also updated the retort HTML structure to better accomodate long retort lists, particularly on mobile

https://github.com/gdpelican/retort/commit/a9740c2a84a1de89c66b5c5cf865e6118e535d72

[th21]

Thank you, it works!

[Vaping_Community]

Retorts on Mobile are messed up for me in the latest update

[Vaping_Community]

I think the retorts container should be above or below the toolbar, preferably above, this gives us a lot more room to work with CSS wise

[th21]

Est-il possible d’utiliser l’explorateur de données ou la console pour trouver la liste des emojis les plus utilisés ? J’ai examiné la table plugin_store_rows mais je n’ai rien trouvé d’utile.

[bsawicki (Brian Sawicki)]

Bonjour, l’infobulle avec laquelle les utilisateurs ont réagi aux répliques est maintenant cassée sur mobile. J’ai essayé de jouer avec z-index mais je n’ai pas réussi à la réparer avec du CSS personnalisé. Y a-t-il une chance que quelqu’un puisse y jeter un coup d’œil ?

[angus (Angus McLeod)]

Ce plugin est en #fin-de-vie. Veuillez utiliser le plugin Reactions.

Discourse Reactions

Summary Discourse Reactions allows users to React to a post from a choice of emojis, rather than only the Like heart. The available emoji selection can be set from the admin settings. Install Guide This plugin is bundled with Discourse core. There is no need to install the plugin separately. Bored of likes in discourse? Here’s something you will definitely love. Overview Discourse-reactions is a plugin that allows user to add their reactions to the …

[wolftune]

Discourse Reactions est un mauvais substitut pour une raison principale : il limite les réactions à une seule par publication. C’est une réduction spectaculaire de l’utilité des réactions par rapport à Retort, qui permet aux gens de donner plusieurs réactions à la même publication.

J’aimerais vraiment que Retort soit maintenu pour cette raison. La meilleure solution serait que Discourse Reactions soit mis à jour pour autoriser plusieurs réactions.

[bsawicki (Brian Sawicki)]

@wolftune

J’aimerais vraiment que Retort soit maintenu pour cette raison. La meilleure solution serait que Discourse Reactions soit mis à jour pour autoriser plusieurs réactions.

L’autre grand inconvénient est que Retort vous permet de choisir parmi tous les émojis disponibles, alors que vous devez définir un ensemble d’émojis pour les réactions Discourse. Si les réactions Discourse avaient ces deux fonctionnalités, je supprimerais volontiers Retort, mais jusqu’à ce que ce soit le cas, mes utilisateurs ne seront pas contents si je leur dis qu’ils perdent l’accès à 95 % des réactions par émojis.

[JammyDodger]

Il y a un sujet de Feature qui semble prometteur…

Add ... option to Discourse Reactions

Add the moment discourse-reactions is limited to a static number of reactions. In some communities it makes sense to give full flexibility so people can pick any reaction from the of emojis. The idea would be If enable all reactions is enabled for the plugin. Render a ... in the reaction menu When clicked let users pick from full reaction list Keep last 3 non standard choices in the default tray @j.jaffeux any thoughts here

[bsawicki (Brian Sawicki)]

Oui, si tout cela est mis en œuvre, je pense que je pourrais facilement convaincre ma base d’utilisateurs de migrer. C’est juste un peu nul de devoir abandonner l’alternative avant que ce ne soit entièrement disponible.