Discourse Web Page Watermark

Sorry, I fixed my other TC and completely forgot about this one.

Will take a look this weekend.

3 Likes

@pfaffman

The PR below modernizes the component to work with latest version of Discourse

Can you take it for a spin???

3 Likes

I pulled in the latest from GitHub - megothss/discourse-watermark: A theme component to add watermarks to Discourse and I’m still getting this:


ï»ż
watermark-background-widget.js:140 Uncaught (in promise) ReferenceError: Ember is not defined
    at i.init (watermark-background-widget.js:140:13)
    at new C (widget.js:176:10)
    at new i (widget.js:92:18)
    at b.rerenderWidget (mount-widget.js:164:23)
    at invoke (backburner.js.js:280:1)
    at d.flush (backburner.js.js:197:1)
    at p.flush (backburner.js.js:358:1)
    at B._end (backburner.js.js:798:1)
    at B._boundAutorunEnd (backburner.js.js:523:1)
ï»ż

2 Likes

I didn’t merge it yet.

You need to try the glimmer branch.

Sorry, I should’ve mentioned that.

2 Likes

Looks like it’s working! Thanks!

Please let me know when you merge it.

3 Likes

It’s merged. :smiley:

3 Likes

Hope it can support pictures.
Question 1: When the picture is directly moved to the desktop, the picture has no watermark.
Question 2: When the picture is dark, the watermark is not visible.

3 Likes