Dismissing notifications about theme updates fails

[Moin]

I got excited when I found the new dismiss button at my admin dashboard. However after clicking it I was a little disappointed. Is this how it is supposed to work?

[ondrej]

Seemed to work better in September

I’ve not had this pop up since it was released as I keep on top of the TC updates.

[ted (Ted Johansson)]

Hello, @Moin!

Thanks for the report. Since the error message is thoroughly unhelpful it’s hard to say exactly what happened here, but I’ve gone over the code and found at least two things that can cause an error:

1. The notice was already dismissed by another admin or in another tab.
2. The user trying to dismiss isn’t an admin. (This can’t be the problem above, because the error is different.)

I have added fixes for these two cases this morning. I’ll leave this topic open for a while to see if it happens again.

---

https://github.com/discourse/discourse/pull/29099

https://github.com/discourse/discourse/pull/29103

[Moin]

@ted

The notice was already dismissed by another admin or in another tab.

Wouldn’t the notice still disappear in that case after some time?

[ted (Ted Johansson)]

@Moin

Wouldn’t the notice still disappear in that case after some time?

Yes. It would disappear the next time you reload the page.

[Moin]

It’s still there

[ted (Ted Johansson)]

There was another fix needed for this to work on our hosting.

You can now dismiss this message. However, if the underlying problem isn’t fixed, it will come back when you reload the page.

This is known behaviour. The current feature is to get rid of “stuck” or one-off notices. We’re working on extending this functionality to let you “snooze” these notifications for a set time frame, so they won’t show up immediately again.