Document.createTextNode("\u{feff}") in quote-button.js.es6 breaks the latest Opera Browser

dmitry_fedyuk · July 30, 2015, 3:37pm

The message in Developer Console:

Uncaught SyntaxError: Unexpected token ILLEGAL

Opera 30.0.1835.125

discourse/discourse/blob/v1.4.0.beta6/app/assets/javascripts/discourse/controllers/quote-button.js.es6#L53


if (this.get('buffer') === selectedText) return;

// we need to retrieve the post data from the posts collection in the topic controller
const postStream = this.get('controllers.topic.model.postStream');
this.set('post', postStream.findLoadedPost(postId));
this.set('buffer', selectedText);

// create a marker element
const markerElement = document.createElement("span");
// containing a single invisible character
markerElement.appendChild(document.createTextNode("\u{feff}"));

// collapse the range at the beginning/end of the selection
range.collapse(!Discourse.Mobile.isMobileDevice);
// and insert it at the start of our selection range
range.insertNode(markerElement);

// retrieve the position of the marker
const markerOffset = $(markerElement).offset(),
      $quoteButton = $('.quote-button');

dmitry_fedyuk · July 30, 2015, 4:03pm

I have quick fixed it for myself by replacing from "\u{feff}" to "".

eviltrout · July 30, 2015, 7:20pm

I tried on the latest Opera on OSX and could not reproduce the bug. However the error seems to be that it doesn’t understand the ES6 unicode format, which we should be transpiling. I added it as an option to babel:

https://github.com/discourse/discourse/commit/3c742918fe581f0752d1cfd3d0995923a908674b

Could you upgrade to our latest and try again? It should be transpiled properly now.

codinghorror · July 31, 2015, 9:10pm

This topic was automatically closed after 24 hours. New replies are no longer allowed.

Topic		Replies	Views
Quoting Blocked on opera browser feature	4	724	June 13, 2018
Arabic comments in code block don't work in Opera ux	5	1427	July 3, 2020
"Unknown error saving post" when starting new topic with inline code support	11	1625	October 2, 2018
Test Watched Words is Broken bug watched-words	3	418	June 9, 2023
Unable to reply due to javascript error [Quick Quote theme component] support	4	382	October 27, 2023

Document.createTextNode("\u{feff}") in quote-button.js.es6 breaks the latest Opera Browser

Related Topics